eina_log: ensure that we do not spam journald with our intree binaries
authorMarcel Hollerbach <mail@marcel-hollerbach.de>
Mon, 23 Sep 2019 12:11:51 +0000 (14:11 +0200)
committerJongmin Lee <jm105.lee@samsung.com>
Mon, 23 Sep 2019 21:32:19 +0000 (06:32 +0900)
EFL_RUN_IN_TREE is set for all binaries that are executed during build
time, and test suites. With this commit we are ensuring that we are not
sending messages during that time to journald, otherwise we would waste
a lot of time + we would create a lot of unneccessary log messages.

(eina test suite runtime with journald hook: 11.21s without journald
hook: 0.57s)

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D10076

src/lib/eina/eina_log.c

index b52f504..31bd818 100644 (file)
@@ -1559,7 +1559,7 @@ eina_log_init(void)
 #endif
 
 #ifdef HAVE_SYSTEMD
-   if (getenv("NOTIFY_SOCKET"))
+   if (getenv("NOTIFY_SOCKET") && !getenv("EFL_RUN_IN_TREE"))
       _print_cb = eina_log_print_cb_journald;
 #endif