QQuickGridMesh: Avoid a signal connection per mesh instance by just calling the signa...

This can be instantiated a fair number of times, leading to a lot of signal
connections. Since the signal is so simple, just place a function call inline
and avoid unnecessary allocations.

Change-Id: I031245c46bf797898f22ed991d0e97d73728bdf5
Reviewed-by: Michael Brasser <michael.brasser@live.com>
Reviewed-by: Gunnar Sletta <gunnar@sletta.org>

diff --git a/src/quick/items/qquickshadereffectmesh.cpp b/src/quick/items/qquickshadereffectmesh.cpp
index 1eab3b4..4100594 100644 (file)
--- a/src/quick/items/qquickshadereffectmesh.cpp
+++ b/src/quick/items/qquickshadereffectmesh.cpp
@@ -59,7 +59,6 @@ QQuickGridMesh::QQuickGridMesh(QObject *parent)
     : QQuickShaderEffectMesh(parent)
     , m_resolution(1, 1)
 {
-    connect(this, SIGNAL(resolutionChanged()), this, SIGNAL(geometryChanged()));
 }
 
 QSGGeometry *QQuickGridMesh::updateGeometry(QSGGeometry *geometry, const QVector<QByteArray> &attributes, const QRectF &srcRect, const QRectF &dstRect)
@@ -204,6 +203,7 @@ void QQuickGridMesh::setResolution(const QSize &res)
     }
     m_resolution = res;
     emit resolutionChanged();
+    emit geometryChanged();
 }
 
 QSize QQuickGridMesh::resolution() const