dmaengine: zx: remove redundant irqsave in hardIRQ
authorBarry Song <song.bao.hua@hisilicon.com>
Sat, 12 Sep 2020 09:40:36 +0000 (21:40 +1200)
committerVinod Koul <vkoul@kernel.org>
Fri, 18 Sep 2020 07:00:50 +0000 (12:30 +0530)
Running in hardIRQ context, disabling IRQ is redundant.

Cc: Jun Nie <jun.nie@linaro.org>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Barry Song <song.bao.hua@hisilicon.com>
Link: https://lore.kernel.org/r/20200912094036.32112-1-song.bao.hua@hisilicon.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/zx_dma.c

index 5fe2e8b..b057582 100644 (file)
@@ -285,9 +285,7 @@ static irqreturn_t zx_dma_int_handler(int irq, void *dev_id)
                p = &d->phy[i];
                c = p->vchan;
                if (c) {
-                       unsigned long flags;
-
-                       spin_lock_irqsave(&c->vc.lock, flags);
+                       spin_lock(&c->vc.lock);
                        if (c->cyclic) {
                                vchan_cyclic_callback(&p->ds_run->vd);
                        } else {
@@ -295,7 +293,7 @@ static irqreturn_t zx_dma_int_handler(int irq, void *dev_id)
                                p->ds_done = p->ds_run;
                                task = 1;
                        }
-                       spin_unlock_irqrestore(&c->vc.lock, flags);
+                       spin_unlock(&c->vc.lock);
                        irq_chan |= BIT(i);
                }
        }