greybus: uart: Fix the memory leak in connection init

If alloc minor is error, gb_tty should free.

Signed-off-by: Phong Tran <tranmanphong@gmail.com>
Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>

diff --git a/drivers/staging/greybus/uart.c b/drivers/staging/greybus/uart.c
index 47de9698f50c224e82a183b44a0471bcdb1a2397..590bc9f5d0be4ce128dccf6a2ee57cd07f8929e6 100644 (file)
--- a/drivers/staging/greybus/uart.c
+++ b/drivers/staging/greybus/uart.c
@@ -618,9 +618,11 @@ static int gb_uart_connection_init(struct gb_connection *connection)
                if (minor == -ENOSPC) {
                        dev_err(&connection->dev,
                                "no more free minor numbers\n");
-                       return -ENODEV;
+                       retval = -ENODEV;
+                       goto error_version;
                }
-               return minor;
+               retval = minor;
+               goto error_version;
        }
 
        gb_tty->minor = minor;