Fixes various compiler warnings
authorArnaud Renevier <a.renevier@samsung.com>
Wed, 6 May 2015 22:55:37 +0000 (15:55 -0700)
committerYoungsoo Choi <kenshin.choi@samsung.com>
Tue, 10 Jul 2018 06:57:09 +0000 (06:57 +0000)
Fixes an unused variable and a suggested parentheses warning.

Also, WrtUrlParseBase is a virtual class. So, it needs a virtual
destructor.

Change-Id: I363167fd6dc49ef68886a274442f80718a0071da
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
tizen_src/chromium_impl/content/common/wrt/wrt_url_parse.h
tizen_src/ewk/efl_integration/content_browser_client_efl.cc
tizen_src/ewk/efl_integration/web_contents_delegate_efl.cc

index a695ea9..4ba1a23 100644 (file)
@@ -12,8 +12,9 @@ namespace content {
 class WrtUrlParseBase {
  public:
   virtual GURL parseUrl(const GURL& url) const = 0;
+  virtual ~WrtUrlParseBase() {}
 };
 
 } // namespace content
 
-#endif // WRT_URL_PARSE_H
\ No newline at end of file
+#endif // WRT_URL_PARSE_H
index a240eea..75f84a1 100644 (file)
@@ -124,7 +124,7 @@ void ContentBrowserClientEfl::DispatchPopupBlockedOnUIThread(
       RenderWidgetHost::GetRenderWidgetHosts());
   RenderWidgetHost* widget = NULL;
 
-  while (widget = widgets->GetNextHost())
+  while ((widget = widgets->GetNextHost()))
     if (widget->GetProcess()->GetID() == render_process_id)
       break;
 
@@ -255,7 +255,7 @@ void ContentBrowserClientEfl::RenderProcessWillLaunch(
   scoped_ptr<RenderWidgetHostIterator> widgets(RenderWidgetHost::GetRenderWidgetHosts());
   RenderWidgetHost* widget = NULL;
 
-  while (widget = widgets->GetNextHost())
+  while ((widget = widgets->GetNextHost()))
     if (widget->GetProcess() == host)
       break;
 
index 5d752c4..952f293 100644 (file)
@@ -575,7 +575,6 @@ void WebContentsDelegateEfl::OpenDateTimeDialog(
     double max,
     double step,
     const std::vector<DateTimeSuggestion>& suggestions) {
-  int inputPickerType;
   web_view_->InputPickerShow(dialog_type, dialog_value);
 }
 } //namespace content