Revert "[lldb] Make TestExprDiagnostics.py pass again after enabling Fix-Its in test"
authorDavide Italiano <ditaliano@apple.com>
Mon, 30 Mar 2020 20:58:18 +0000 (13:58 -0700)
committerDavide Italiano <ditaliano@apple.com>
Mon, 30 Mar 2020 20:58:18 +0000 (13:58 -0700)
This reverts commit 502a06fcdafa637a9890da16c2734bc1a36010f6 as it
breaks the macOS bots. Raph will take a look and re-commit.

lldb/test/API/commands/expression/diagnostics/TestExprDiagnostics.py

index b5eb552..da29d7b 100644 (file)
@@ -60,10 +60,10 @@ class ExprDiagnosticsTestCase(TestBase):
         self.assertIn("<user expression 3>:1:10", value.GetError().GetCString())
 
         # Multiline top-level expressions.
-        value = frame.EvaluateExpression("void x() {}\nvoid foo;", top_level_opts)
+        value = frame.EvaluateExpression("void x() {}\nvoid foo(unknown_type x) {}", top_level_opts)
         self.assertFalse(value.GetError().Success())
-        self.assertIn("\nvoid foo;\n     ^", value.GetError().GetCString())
-        self.assertIn("<user expression 4>:2:6", value.GetError().GetCString())
+        self.assertIn("\nvoid foo(unknown_type x) {}\n         ^\n", value.GetError().GetCString())
+        self.assertIn("<user expression 4>:2:10", value.GetError().GetCString())
 
         # Test that we render Clang's 'notes' correctly.
         value = frame.EvaluateExpression("struct SFoo{}; struct SFoo { int x; };", top_level_opts)