power: supply: bq25890: Fix enum conversion in bq25890_power_supply_set_property()
authorNathan Chancellor <nathan@kernel.org>
Mon, 12 Sep 2022 14:15:53 +0000 (07:15 -0700)
committerSebastian Reichel <sebastian.reichel@collabora.com>
Wed, 14 Sep 2022 10:00:39 +0000 (12:00 +0200)
Clang warns:

  drivers/power/supply/bq25890_charger.c:625:40: error: implicit conversion from enumeration type 'enum bq25890_fields' to different enumeration type 'enum bq25890_table_ids' [-Werror,-Wenum-conversion]
                  lval = bq25890_find_idx(val->intval, F_IINLIM);
                         ~~~~~~~~~~~~~~~~              ^~~~~~~~
  1 error generated.

Use the proper value from the right enumerated type, TBL_IINLIM, so
there is no more implcit conversion. The numerical values of F_IINLIM
and TBL_IINLIM happen to be the same so there is no change in behavior.

Fixes: 4a4748f28b0b ("power: supply: bq25890: Add support for setting IINLIM")
Link: https://github.com/ClangBuiltLinux/linux/issues/1707
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Reviewed-by: Marek Vasut <marex@denx.de>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
drivers/power/supply/bq25890_charger.c

index f5368be32843bf811433c8c04e71f56dc120adc2..e6bd60fef0f6d2cd9dcb5801a2f89d0b7ed31c62 100644 (file)
@@ -622,7 +622,7 @@ static int bq25890_power_supply_set_property(struct power_supply *psy,
 
        switch (psp) {
        case POWER_SUPPLY_PROP_INPUT_CURRENT_LIMIT:
-               lval = bq25890_find_idx(val->intval, F_IINLIM);
+               lval = bq25890_find_idx(val->intval, TBL_IINLIM);
                return bq25890_field_write(bq, F_IINLIM, lval);
        default:
                return -EINVAL;