dm crypt: drop device ref in ctr error path
authorDmitry Monakhov <dmonakhov@openvz.org>
Fri, 19 Oct 2007 21:38:37 +0000 (22:38 +0100)
committerAlasdair G Kergon <agk@redhat.com>
Sat, 20 Oct 2007 01:00:59 +0000 (02:00 +0100)
Add a missing 'dm_put_device' in an error path in crypt target constructor.

Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org>
Signed-off-by: Milan Broz <mbroz@redhat.com>
Signed-off-by: Alasdair G Kergon <agk@redhat.com>
drivers/md/dm-crypt.c

index 64fee90..ecd9ef0 100644 (file)
@@ -861,7 +861,7 @@ static int crypt_ctr(struct dm_target *ti, unsigned int argc, char **argv)
                cc->iv_mode = kmalloc(strlen(ivmode) + 1, GFP_KERNEL);
                if (!cc->iv_mode) {
                        ti->error = "Error kmallocing iv_mode string";
-                       goto bad5;
+                       goto bad_iv_mode;
                }
                strcpy(cc->iv_mode, ivmode);
        } else
@@ -870,6 +870,8 @@ static int crypt_ctr(struct dm_target *ti, unsigned int argc, char **argv)
        ti->private = cc;
        return 0;
 
+bad_iv_mode:
+       dm_put_device(ti, cc->dev);
 bad5:
        bioset_free(cc->bs);
 bad_bs: