Enhance few logs around application launching.

It was reported that some checks during our launching could be more verbose
and informative about what is going on. Added few more sentences to clearly
state if application process is improperly setup and why.

Change-Id: I47d6578dceff957cf76aa8ee690420d5a5cc9d7f

diff --git a/src/client/check-proper-drop.cpp b/src/client/check-proper-drop.cpp
index bc9ac8146a1a81de88e4a465bd69ab2ee9c59413..ccb0b6888a0d9b155e7f67d960d612107d35c272 100644 (file)
--- a/src/client/check-proper-drop.cpp
+++ b/src/client/check-proper-drop.cpp
@@ -66,8 +66,10 @@ void CheckProperDrop::getThreads()
 bool CheckProperDrop::checkThreads()
 {
 #define REPORT_THREAD_ERROR(TID, NAME, VAL1, VAL2) {                           \
-    LogError("Invalid value of " << (NAME) << " for thread " << (TID) << "."   \
-        << ". Process has " << (VAL1) << ", thread has " << (VAL2) << ".");    \
+    LogError("Invalid value of " << (NAME) << " for thread " << (TID) << ". "  \
+        << "Process has " << (VAL1) << ", thread has " << (VAL2) << ". "       \
+        << "Application candidate process not prepared properly for launch. "  \
+        << (NAME) <<  " values should be same for all threads.");              \
     return false;                                                              \
 }
 

diff --git a/src/client/client-security-manager.cpp b/src/client/client-security-manager.cpp
index ba026c95399b7b68b8e2c05e1617fcc30360a11c..24ab61bb0097d4d97b7e6f2a55b80579d42256d2 100644 (file)
--- a/src/client/client-security-manager.cpp
+++ b/src/client/client-security-manager.cpp
@@ -853,7 +853,8 @@ int security_manager_prepare_app_candidate(void)
 
         FS::FileNameVector files = FS::getSubDirectoriesFromDirectory("/proc/self/task");
         if (files.size() > 3) { // 3 because we have ., we have .. and we should have only one thread here
-            LogError("Too many threads in current process, can't switch to new namespace safely in multithreaded program");
+            LogError("Too many threads in current process, can't switch to new namespace safely in multithreaded program. "\
+                     "Abort launching the application, as it may have too high privileges and pose risk to the system.");
             return SECURITY_MANAGER_ERROR_INPUT_PARAM;
         }
         return MountNS::createMountNamespace();