ProcessResult: refined confused method usage

Change-Id: If3a1ed3c7cf44f25d436877cfdd6f48ae6913dd4
Signed-off-by: SeokYeon Hwang <syeon.hwang@samsung.com>

diff --git a/src/org/tizen/emulator/manager/vms/helper/HelperClass.java b/src/org/tizen/emulator/manager/vms/helper/HelperClass.java
index a2c55b1..6345493 100644 (file)
--- a/src/org/tizen/emulator/manager/vms/helper/HelperClass.java
+++ b/src/org/tizen/emulator/manager/vms/helper/HelperClass.java
@@ -228,12 +228,15 @@ public class HelperClass {
                }
        }
 
+       static final int EXIT_VALUE_PROCESS_STARTED_FAILURE = -1;
+
        public static ProcessResult runProcess(List<String> cmd) {
                return runProcess(cmd, null);
        }
 
        public static ProcessResult runProcess(List<String> cmd, File directory) {
-               ProcessResult result = new ProcessResult();
+
+               ProcessResult result = null;
                ProcessBuilder pb = new ProcessBuilder(cmd);
                int exitValue = 0;
                Process process = null;
@@ -248,25 +251,17 @@ public class HelperClass {
                        List<String> stdErr = ProcessOutputReader.readStdErr(process, cmd.toString());
                        exitValue = process.waitFor();
 
-                       if (exitValue != 0) {
-                               EMLogger.getLogger().warning("Command returns fail:" +
-                                               "cmd : " + cmd.toString() + ", return : " + exitValue);
-                               result.setResult(false);
-
-                       } else {
-                               result.setResult(true);
-                       }
-                       result.setExitValue(exitValue);
+                       result = new ProcessResult(true, exitValue);
                        result.setStdOutMsg(stdOut);
                        result.setStdErrMsg(stdErr);
 
                } catch (IOException e) {
                        EMLogger.getLogger().warning("Run process fail. " + e.getMessage());
-                       result.setResult(false);
+                       result = new ProcessResult(false, EXIT_VALUE_PROCESS_STARTED_FAILURE);
                        result.setStdErrMsg(Arrays.asList(e.getMessage()));
 
                } catch (InterruptedException e) {
-                       result.setResult(false);
+                       result = new ProcessResult(false, EXIT_VALUE_PROCESS_STARTED_FAILURE);
                        EMLogger.getLogger().info("Process end with interrupt. " + e.getMessage());
                        result.setStdErrMsg(Arrays.asList(e.getMessage()));
                }

diff --git a/src/org/tizen/emulator/manager/vms/helper/ProcessResult.java b/src/org/tizen/emulator/manager/vms/helper/ProcessResult.java
index 0d1cb72..e23803e 100644 (file)
--- a/src/org/tizen/emulator/manager/vms/helper/ProcessResult.java
+++ b/src/org/tizen/emulator/manager/vms/helper/ProcessResult.java
@@ -32,12 +32,13 @@ import java.util.ArrayList;
 import java.util.List;
 
 public class ProcessResult {
-       boolean result;
+       boolean isStartedSuccessfully;
        int exitValue;
        List<String> stdOutMsg = new ArrayList<String>();
        List<String> stdErrMsg = new ArrayList<String>();
 
-       public void setExitValue(int exitValue) {
+       ProcessResult(boolean isStartedSuccessfully, int exitValue) {
+               this.isStartedSuccessfully = isStartedSuccessfully;
                this.exitValue = exitValue;
        }
 
@@ -45,12 +46,12 @@ public class ProcessResult {
                return exitValue;
        }
 
-       public boolean isSuccess() {
-               return result;
+       public boolean isStartedSuccessfully() {
+               return isStartedSuccessfully;
        }
 
-       public void setResult(boolean result) {
-               this.result = result;
+       public boolean isSuccess() {
+               return isStartedSuccessfully && exitValue == 0;
        }
 
        public List<String> getStdOutMsg() {