Fix warnings on shadowing data members with arguments
authorJoão Abecasis <joao.abecasis@nokia.com>
Tue, 21 Feb 2012 15:32:35 +0000 (16:32 +0100)
committerQt by Nokia <qt-info@nokia.com>
Wed, 22 Feb 2012 00:53:15 +0000 (01:53 +0100)
Example emitted by GCC 4.2.1:

    warning: declaration of ‘iter’ shadows a member of 'this'

Change-Id: I288da01c511a1404bf41881a6c96a5f3cd00d0a7
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@nokia.com>
src/corelib/tools/qarraydataops.h

index cfb1863..1b8ed33 100644 (file)
@@ -163,9 +163,9 @@ struct QGenericArrayOps
 
         struct Destructor
         {
-            Destructor(T *&iter)
-                : iter(&iter)
-                , end(iter)
+            Destructor(T *&it)
+                : iter(&it)
+                , end(it)
             {
             }
 
@@ -231,10 +231,10 @@ struct QMovableArrayOps
 
         struct ReversibleDisplace
         {
-            ReversibleDisplace(T *begin, T *end, size_t displace)
-                : begin(begin)
-                , end(end)
-                , displace(displace)
+            ReversibleDisplace(T *start, T *finish, size_t diff)
+                : begin(start)
+                , end(finish)
+                , displace(diff)
             {
                 ::memmove(begin + displace, begin, (end - begin) * sizeof(T));
             }
@@ -255,7 +255,7 @@ struct QMovableArrayOps
 
         struct CopyConstructor
         {
-            CopyConstructor(T *where) : where(where) {}
+            CopyConstructor(T *w) : where(w) {}
 
             void copy(const T *src, const T *const srcEnd)
             {