net: stmmac: dwmac-sun8i: Return void from PHY unpower
authorSamuel Holland <samuel@sholland.org>
Wed, 17 Feb 2021 04:20:02 +0000 (22:20 -0600)
committerDavid S. Miller <davem@davemloft.net>
Wed, 17 Feb 2021 21:42:56 +0000 (13:42 -0800)
This is a deinitialization function that always returned zero, and that
return value was always ignored. Have it return void instead.

Reviewed-by: Chen-Yu Tsai <wens@csie.org>
Signed-off-by: Samuel Holland <samuel@sholland.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c

index a5e0eff..8e50501 100644 (file)
@@ -820,15 +820,14 @@ static int sun8i_dwmac_power_internal_phy(struct stmmac_priv *priv)
        return 0;
 }
 
-static int sun8i_dwmac_unpower_internal_phy(struct sunxi_priv_data *gmac)
+static void sun8i_dwmac_unpower_internal_phy(struct sunxi_priv_data *gmac)
 {
        if (!gmac->internal_phy_powered)
-               return 0;
+               return;
 
        clk_disable_unprepare(gmac->ephy_clk);
        reset_control_assert(gmac->rst_ephy);
        gmac->internal_phy_powered = false;
-       return 0;
 }
 
 /* MDIO multiplexing switch function