[lldb] Remove scoped timer from high firing and fast running ExtractUnitDIENoDwoIfNeeded
authorDave Lee <davelee.com@gmail.com>
Thu, 29 Sep 2022 23:01:49 +0000 (16:01 -0700)
committerDave Lee <davelee.com@gmail.com>
Sat, 1 Oct 2022 16:58:40 +0000 (09:58 -0700)
Profiles show that `DWARFUnit::ExtractUnitDIENoDwoIfNeeded` is both high firing (tens of thousands of calls) and fast running (15 µs mean).

Timers like this are noise and load for profiling systems, and can be removed.

rdar://100326595

Differential Revision: https://reviews.llvm.org/D134920

lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp

index 46204ba..21ef765 100644 (file)
@@ -51,8 +51,6 @@ void DWARFUnit::ExtractUnitDIENoDwoIfNeeded() {
     return; // Already parsed
 
   ElapsedTime elapsed(m_dwarf.GetDebugInfoParseTimeRef());
-  LLDB_SCOPED_TIMERF("%8.8x: DWARFUnit::ExtractUnitDIENoDwoIfNeeded()",
-                     GetOffset());
 
   // Set the offset to that of the first DIE and calculate the start of the
   // next compilation unit header.