mt76: mt7615: Fix assigning negative values to unsigned variable
authorYang Li <yang.lee@linux.alibaba.com>
Mon, 14 Feb 2022 01:58:21 +0000 (09:58 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 13 Apr 2022 18:59:07 +0000 (20:59 +0200)
[ Upstream commit 9273ffcc9a11942bd586bb42584337ef3962b692 ]

Smatch reports the following:
drivers/net/wireless/mediatek/mt76/mt7615/mac.c:1865
mt7615_mac_adjust_sensitivity() warn: assigning (-110) to unsigned
variable 'def_th'
drivers/net/wireless/mediatek/mt76/mt7615/mac.c:1865
mt7615_mac_adjust_sensitivity() warn: assigning (-98) to unsigned
variable 'def_th'

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Signed-off-by: Felix Fietkau <nbd@nbd.name>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/wireless/mediatek/mt76/mt7615/mac.c

index eb7bda9..8f4a5d4 100644 (file)
@@ -1732,7 +1732,7 @@ mt7615_mac_adjust_sensitivity(struct mt7615_phy *phy,
        struct mt7615_dev *dev = phy->dev;
        int false_cca = ofdm ? phy->false_cca_ofdm : phy->false_cca_cck;
        bool ext_phy = phy != &dev->phy;
-       u16 def_th = ofdm ? -98 : -110;
+       s16 def_th = ofdm ? -98 : -110;
        bool update = false;
        s8 *sensitivity;
        int signal;