tty: synclink: Reuse an existing error handling path
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sun, 17 Sep 2017 19:10:14 +0000 (21:10 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 18 Sep 2017 16:31:48 +0000 (18:31 +0200)
In order to avoid code duplication and to be more consistent with the
other error handling paths in this function, we should 'goto errout'.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/synclink.c

index 3be9811..27db781 100644 (file)
@@ -4098,8 +4098,7 @@ static int mgsl_claim_resources(struct mgsl_struct *info)
                if (request_dma(info->dma_level,info->device_name) < 0){
                        printk( "%s(%d):Can't request DMA channel on device %s DMA=%d\n",
                                __FILE__,__LINE__,info->device_name, info->dma_level );
-                       mgsl_release_resources( info );
-                       return -ENODEV;
+                       goto errout;
                }
                info->dma_requested = true;