bnx2: clean up unnecessary MSI/MSI-X capability find
authorYijing Wang <wangyijing@huawei.com>
Thu, 8 Aug 2013 13:02:22 +0000 (21:02 +0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 9 Aug 2013 20:49:51 +0000 (13:49 -0700)
PCI core will initialize device MSI/MSI-X capability in
pci_msi_init_pci_dev(). So device driver should use
pci_dev->msi_cap/msix_cap to determine whether the device
support MSI/MSI-X instead of using
pci_find_capability(pci_dev, PCI_CAP_ID_MSI/MSIX).
Access to PCIe device config space again will consume more time.

Signed-off-by: Yijing Wang <wangyijing@huawei.com>
Cc: Michael Chan <mchan@broadcom.com>
Cc: netdev@vger.kernel.org
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/bnx2.c

index 6fdfc18..4148058 100644 (file)
@@ -8139,13 +8139,13 @@ bnx2_init_board(struct pci_dev *pdev, struct net_device *dev)
 
        if (BNX2_CHIP(bp) == BNX2_CHIP_5709 &&
            BNX2_CHIP_REV(bp) != BNX2_CHIP_REV_Ax) {
-               if (pci_find_capability(pdev, PCI_CAP_ID_MSIX))
+               if (pdev->msix_cap)
                        bp->flags |= BNX2_FLAG_MSIX_CAP;
        }
 
        if (BNX2_CHIP_ID(bp) != BNX2_CHIP_ID_5706_A0 &&
            BNX2_CHIP_ID(bp) != BNX2_CHIP_ID_5706_A1) {
-               if (pci_find_capability(pdev, PCI_CAP_ID_MSI))
+               if (pdev->msi_cap)
                        bp->flags |= BNX2_FLAG_MSI_CAP;
        }