wl1271: Fix 32 bit register read related endiannes bug
authorJuuso Oikarinen <juuso.oikarinen@nokia.com>
Fri, 7 May 2010 08:38:59 +0000 (11:38 +0300)
committerJohn W. Linville <linville@tuxdriver.com>
Fri, 7 May 2010 18:57:18 +0000 (14:57 -0400)
Reading single registers did not pay attention to data endianness. This patch
fix that.

Signed-off-by: Juuso Oikarinen <juuso.oikarinen@nokia.com>
Reviewed-by: Luciano Coelho <luciano.coelho@nokia.com>
Signed-off-by: Luciano Coelho <luciano.coelho@nokia.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/wl12xx/wl1271.h
drivers/net/wireless/wl12xx/wl1271_io.h

index 3e1769d..6f1b6b5 100644 (file)
@@ -481,7 +481,7 @@ struct wl1271 {
        struct wl1271_stats stats;
        struct wl1271_debugfs debugfs;
 
-       u32 buffer_32;
+       __le32 buffer_32;
        u32 buffer_cmd;
        u32 buffer_busyword[WL1271_BUSY_WORD_CNT];
 
index d8837ef..bc806c7 100644 (file)
@@ -74,12 +74,12 @@ static inline u32 wl1271_raw_read32(struct wl1271 *wl, int addr)
        wl1271_raw_read(wl, addr, &wl->buffer_32,
                            sizeof(wl->buffer_32), false);
 
-       return wl->buffer_32;
+       return le32_to_cpu(wl->buffer_32);
 }
 
 static inline void wl1271_raw_write32(struct wl1271 *wl, int addr, u32 val)
 {
-       wl->buffer_32 = val;
+       wl->buffer_32 = cpu_to_le32(val);
        wl1271_raw_write(wl, addr, &wl->buffer_32,
                             sizeof(wl->buffer_32), false);
 }