gfs2: simplify gfs2_freeze by removing case
authorBob Peterson <rpeterso@redhat.com>
Mon, 29 Apr 2019 15:36:23 +0000 (09:36 -0600)
committerAndreas Gruenbacher <agruenba@redhat.com>
Thu, 27 Jun 2019 19:26:58 +0000 (21:26 +0200)
Function gfs2_freeze had a case statement that simply checked the
error code, but the break statements just made the logic hard to
read. This patch simplifies the logic in favor of a simple if.

Signed-off-by: Bob Peterson <rpeterso@redhat.com>
Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
fs/gfs2/super.c

index 129ae43..3eae973 100644 (file)
@@ -1023,20 +1023,14 @@ static int gfs2_freeze(struct super_block *sb)
                if (!error)
                        break;
 
-               switch (error) {
-               case -EBUSY:
+               if (error == -EBUSY)
                        fs_err(sdp, "waiting for recovery before freeze\n");
-                       break;
-
-               default:
+               else
                        fs_err(sdp, "error freezing FS: %d\n", error);
-                       break;
-               }
 
                fs_err(sdp, "retrying...\n");
                msleep(1000);
        }
-       error = 0;
        set_bit(SDF_FS_FROZEN, &sdp->sd_flags);
 out:
        mutex_unlock(&sdp->sd_freeze_mutex);