projects / platform / kernel / linux-starfive.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 03d4d13)
selftests/bpf: Asm tests for the verifier regalloc tracking.
authorAlexei Starovoitov <ast@kernel.org>
Fri, 9 Oct 2020 01:12:40 +0000 (18:12 -0700)
committerDaniel Borkmann <daniel@iogearbox.net>
Fri, 9 Oct 2020 20:03:06 +0000 (22:03 +0200)
Add asm tests for register allocator tracking logic.

Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: Andrii Nakryiko <andrii@kernel.org>
Link: https://lore.kernel.org/bpf/20201009011240.48506-5-alexei.starovoitov@gmail.com
tools/testing/selftests/bpf/verifier/regalloc.c [new file with mode: 0644] patch | blob

diff --git a/tools/testing/selftests/bpf/verifier/regalloc.c b/tools/testing/selftests/bpf/verifier/regalloc.c
new file mode 100644 (file)
index 0000000..ac71b82
--- /dev/null
+++ b/tools/testing/selftests/bpf/verifier/regalloc.c
@@ -0,0 +1,243 @@
+{
+       "regalloc basic",
+       .insns = {
+       BPF_MOV64_REG(BPF_REG_6, BPF_REG_1),
+       BPF_ST_MEM(BPF_DW, BPF_REG_10, -8, 0),
+       BPF_MOV64_REG(BPF_REG_2, BPF_REG_10),
+       BPF_ALU64_IMM(BPF_ADD, BPF_REG_2, -8),
+       BPF_LD_MAP_FD(BPF_REG_1, 0),
+       BPF_EMIT_CALL(BPF_FUNC_map_lookup_elem),
+       BPF_JMP_IMM(BPF_JEQ, BPF_REG_0, 0, 8),
+       BPF_MOV64_REG(BPF_REG_7, BPF_REG_0),
+       BPF_EMIT_CALL(BPF_FUNC_get_prandom_u32),
+       BPF_MOV64_REG(BPF_REG_2, BPF_REG_0),
+       BPF_JMP_IMM(BPF_JSGT, BPF_REG_0, 20, 4),
+       BPF_JMP_IMM(BPF_JSLT, BPF_REG_2, 0, 3),
+       BPF_ALU64_REG(BPF_ADD, BPF_REG_7, BPF_REG_0),
+       BPF_ALU64_REG(BPF_ADD, BPF_REG_7, BPF_REG_2),
+       BPF_LDX_MEM(BPF_DW, BPF_REG_0, BPF_REG_7, 0),
+       BPF_EXIT_INSN(),
+       },
+       .fixup_map_hash_48b = { 4 },
+       .result = ACCEPT,
+       .prog_type = BPF_PROG_TYPE_TRACEPOINT,
+},
+{
+       "regalloc negative",
+       .insns = {
+       BPF_MOV64_REG(BPF_REG_6, BPF_REG_1),
+       BPF_ST_MEM(BPF_DW, BPF_REG_10, -8, 0),
+       BPF_MOV64_REG(BPF_REG_2, BPF_REG_10),
+       BPF_ALU64_IMM(BPF_ADD, BPF_REG_2, -8),
+       BPF_LD_MAP_FD(BPF_REG_1, 0),
+       BPF_EMIT_CALL(BPF_FUNC_map_lookup_elem),
+       BPF_JMP_IMM(BPF_JEQ, BPF_REG_0, 0, 8),
+       BPF_MOV64_REG(BPF_REG_7, BPF_REG_0),
+       BPF_EMIT_CALL(BPF_FUNC_get_prandom_u32),
+       BPF_MOV64_REG(BPF_REG_2, BPF_REG_0),
+       BPF_JMP_IMM(BPF_JSGT, BPF_REG_0, 24, 4),
+       BPF_JMP_IMM(BPF_JSLT, BPF_REG_2, 0, 3),
+       BPF_ALU64_REG(BPF_ADD, BPF_REG_7, BPF_REG_0),
+       BPF_ALU64_REG(BPF_ADD, BPF_REG_7, BPF_REG_2),
+       BPF_LDX_MEM(BPF_B, BPF_REG_0, BPF_REG_7, 0),
+       BPF_EXIT_INSN(),
+       },
+       .fixup_map_hash_48b = { 4 },
+       .result = REJECT,
+       .errstr = "invalid access to map value, value_size=48 off=48 size=1",
+       .prog_type = BPF_PROG_TYPE_TRACEPOINT,
+},
+{
+       "regalloc src_reg mark",
+       .insns = {
+       BPF_MOV64_REG(BPF_REG_6, BPF_REG_1),
+       BPF_ST_MEM(BPF_DW, BPF_REG_10, -8, 0),
+       BPF_MOV64_REG(BPF_REG_2, BPF_REG_10),
+       BPF_ALU64_IMM(BPF_ADD, BPF_REG_2, -8),
+       BPF_LD_MAP_FD(BPF_REG_1, 0),
+       BPF_EMIT_CALL(BPF_FUNC_map_lookup_elem),
+       BPF_JMP_IMM(BPF_JEQ, BPF_REG_0, 0, 9),
+       BPF_MOV64_REG(BPF_REG_7, BPF_REG_0),
+       BPF_EMIT_CALL(BPF_FUNC_get_prandom_u32),
+       BPF_MOV64_REG(BPF_REG_2, BPF_REG_0),
+       BPF_JMP_IMM(BPF_JSGT, BPF_REG_0, 20, 5),
+       BPF_MOV64_IMM(BPF_REG_3, 0),
+       BPF_JMP_REG(BPF_JSGE, BPF_REG_3, BPF_REG_2, 3),
+       BPF_ALU64_REG(BPF_ADD, BPF_REG_7, BPF_REG_0),
+       BPF_ALU64_REG(BPF_ADD, BPF_REG_7, BPF_REG_2),
+       BPF_LDX_MEM(BPF_DW, BPF_REG_0, BPF_REG_7, 0),
+       BPF_EXIT_INSN(),
+       },
+       .fixup_map_hash_48b = { 4 },
+       .result = ACCEPT,
+       .prog_type = BPF_PROG_TYPE_TRACEPOINT,
+},
+{
+       "regalloc src_reg negative",
+       .insns = {
+       BPF_MOV64_REG(BPF_REG_6, BPF_REG_1),
+       BPF_ST_MEM(BPF_DW, BPF_REG_10, -8, 0),
+       BPF_MOV64_REG(BPF_REG_2, BPF_REG_10),
+       BPF_ALU64_IMM(BPF_ADD, BPF_REG_2, -8),
+       BPF_LD_MAP_FD(BPF_REG_1, 0),
+       BPF_EMIT_CALL(BPF_FUNC_map_lookup_elem),
+       BPF_JMP_IMM(BPF_JEQ, BPF_REG_0, 0, 9),
+       BPF_MOV64_REG(BPF_REG_7, BPF_REG_0),
+       BPF_EMIT_CALL(BPF_FUNC_get_prandom_u32),
+       BPF_MOV64_REG(BPF_REG_2, BPF_REG_0),
+       BPF_JMP_IMM(BPF_JSGT, BPF_REG_0, 22, 5),
+       BPF_MOV64_IMM(BPF_REG_3, 0),
+       BPF_JMP_REG(BPF_JSGE, BPF_REG_3, BPF_REG_2, 3),
+       BPF_ALU64_REG(BPF_ADD, BPF_REG_7, BPF_REG_0),
+       BPF_ALU64_REG(BPF_ADD, BPF_REG_7, BPF_REG_2),
+       BPF_LDX_MEM(BPF_DW, BPF_REG_0, BPF_REG_7, 0),
+       BPF_EXIT_INSN(),
+       },
+       .fixup_map_hash_48b = { 4 },
+       .result = REJECT,
+       .errstr = "invalid access to map value, value_size=48 off=44 size=8",
+       .prog_type = BPF_PROG_TYPE_TRACEPOINT,
+},
+{
+       "regalloc and spill",
+       .insns = {
+       BPF_MOV64_REG(BPF_REG_6, BPF_REG_1),
+       BPF_ST_MEM(BPF_DW, BPF_REG_10, -8, 0),
+       BPF_MOV64_REG(BPF_REG_2, BPF_REG_10),
+       BPF_ALU64_IMM(BPF_ADD, BPF_REG_2, -8),
+       BPF_LD_MAP_FD(BPF_REG_1, 0),
+       BPF_EMIT_CALL(BPF_FUNC_map_lookup_elem),
+       BPF_JMP_IMM(BPF_JEQ, BPF_REG_0, 0, 11),
+       BPF_MOV64_REG(BPF_REG_7, BPF_REG_0),
+       BPF_EMIT_CALL(BPF_FUNC_get_prandom_u32),
+       BPF_MOV64_REG(BPF_REG_2, BPF_REG_0),
+       BPF_JMP_IMM(BPF_JSGT, BPF_REG_0, 20, 7),
+       /* r0 has upper bound that should propagate into r2 */
+       BPF_STX_MEM(BPF_DW, BPF_REG_10, BPF_REG_2, -8), /* spill r2 */
+       BPF_MOV64_IMM(BPF_REG_0, 0),
+       BPF_MOV64_IMM(BPF_REG_2, 0), /* clear r0 and r2 */
+       BPF_LDX_MEM(BPF_DW, BPF_REG_3, BPF_REG_10, -8), /* fill r3 */
+       BPF_JMP_REG(BPF_JSGE, BPF_REG_0, BPF_REG_3, 2),
+       /* r3 has lower and upper bounds */
+       BPF_ALU64_REG(BPF_ADD, BPF_REG_7, BPF_REG_3),
+       BPF_LDX_MEM(BPF_DW, BPF_REG_0, BPF_REG_7, 0),
+       BPF_EXIT_INSN(),
+       },
+       .fixup_map_hash_48b = { 4 },
+       .result = ACCEPT,
+       .prog_type = BPF_PROG_TYPE_TRACEPOINT,
+},
+{
+       "regalloc and spill negative",
+       .insns = {
+       BPF_MOV64_REG(BPF_REG_6, BPF_REG_1),
+       BPF_ST_MEM(BPF_DW, BPF_REG_10, -8, 0),
+       BPF_MOV64_REG(BPF_REG_2, BPF_REG_10),
+       BPF_ALU64_IMM(BPF_ADD, BPF_REG_2, -8),
+       BPF_LD_MAP_FD(BPF_REG_1, 0),
+       BPF_EMIT_CALL(BPF_FUNC_map_lookup_elem),
+       BPF_JMP_IMM(BPF_JEQ, BPF_REG_0, 0, 11),
+       BPF_MOV64_REG(BPF_REG_7, BPF_REG_0),
+       BPF_EMIT_CALL(BPF_FUNC_get_prandom_u32),
+       BPF_MOV64_REG(BPF_REG_2, BPF_REG_0),
+       BPF_JMP_IMM(BPF_JSGT, BPF_REG_0, 48, 7),
+       /* r0 has upper bound that should propagate into r2 */
+       BPF_STX_MEM(BPF_DW, BPF_REG_10, BPF_REG_2, -8), /* spill r2 */
+       BPF_MOV64_IMM(BPF_REG_0, 0),
+       BPF_MOV64_IMM(BPF_REG_2, 0), /* clear r0 and r2 */
+       BPF_LDX_MEM(BPF_DW, BPF_REG_3, BPF_REG_10, -8), /* fill r3 */
+       BPF_JMP_REG(BPF_JSGE, BPF_REG_0, BPF_REG_3, 2),
+       /* r3 has lower and upper bounds */
+       BPF_ALU64_REG(BPF_ADD, BPF_REG_7, BPF_REG_3),
+       BPF_LDX_MEM(BPF_DW, BPF_REG_0, BPF_REG_7, 0),
+       BPF_EXIT_INSN(),
+       },
+       .fixup_map_hash_48b = { 4 },
+       .result = REJECT,
+       .errstr = "invalid access to map value, value_size=48 off=48 size=8",
+       .prog_type = BPF_PROG_TYPE_TRACEPOINT,
+},
+{
+       "regalloc three regs",
+       .insns = {
+       BPF_MOV64_REG(BPF_REG_6, BPF_REG_1),
+       BPF_ST_MEM(BPF_DW, BPF_REG_10, -8, 0),
+       BPF_MOV64_REG(BPF_REG_2, BPF_REG_10),
+       BPF_ALU64_IMM(BPF_ADD, BPF_REG_2, -8),
+       BPF_LD_MAP_FD(BPF_REG_1, 0),
+       BPF_EMIT_CALL(BPF_FUNC_map_lookup_elem),
+       BPF_JMP_IMM(BPF_JEQ, BPF_REG_0, 0, 10),
+       BPF_MOV64_REG(BPF_REG_7, BPF_REG_0),
+       BPF_EMIT_CALL(BPF_FUNC_get_prandom_u32),
+       BPF_MOV64_REG(BPF_REG_2, BPF_REG_0),
+       BPF_MOV64_REG(BPF_REG_4, BPF_REG_2),
+       BPF_JMP_IMM(BPF_JSGT, BPF_REG_0, 12, 5),
+       BPF_JMP_IMM(BPF_JSLT, BPF_REG_2, 0, 4),
+       BPF_ALU64_REG(BPF_ADD, BPF_REG_7, BPF_REG_0),
+       BPF_ALU64_REG(BPF_ADD, BPF_REG_7, BPF_REG_2),
+       BPF_ALU64_REG(BPF_ADD, BPF_REG_7, BPF_REG_4),
+       BPF_LDX_MEM(BPF_DW, BPF_REG_0, BPF_REG_7, 0),
+       BPF_EXIT_INSN(),
+       },
+       .fixup_map_hash_48b = { 4 },
+       .result = ACCEPT,
+       .prog_type = BPF_PROG_TYPE_TRACEPOINT,
+},
+{
+       "regalloc after call",
+       .insns = {
+       BPF_MOV64_REG(BPF_REG_6, BPF_REG_1),
+       BPF_ST_MEM(BPF_DW, BPF_REG_10, -8, 0),
+       BPF_MOV64_REG(BPF_REG_2, BPF_REG_10),
+       BPF_ALU64_IMM(BPF_ADD, BPF_REG_2, -8),
+       BPF_LD_MAP_FD(BPF_REG_1, 0),
+       BPF_EMIT_CALL(BPF_FUNC_map_lookup_elem),
+       BPF_JMP_IMM(BPF_JEQ, BPF_REG_0, 0, 10),
+       BPF_MOV64_REG(BPF_REG_7, BPF_REG_0),
+       BPF_EMIT_CALL(BPF_FUNC_get_prandom_u32),
+       BPF_MOV64_REG(BPF_REG_8, BPF_REG_0),
+       BPF_MOV64_REG(BPF_REG_9, BPF_REG_0),
+       BPF_RAW_INSN(BPF_JMP | BPF_CALL, 0, 1, 0, 6),
+       BPF_JMP_IMM(BPF_JSGT, BPF_REG_8, 20, 4),
+       BPF_JMP_IMM(BPF_JSLT, BPF_REG_9, 0, 3),
+       BPF_ALU64_REG(BPF_ADD, BPF_REG_7, BPF_REG_8),
+       BPF_ALU64_REG(BPF_ADD, BPF_REG_7, BPF_REG_9),
+       BPF_LDX_MEM(BPF_DW, BPF_REG_0, BPF_REG_7, 0),
+       BPF_EXIT_INSN(),
+       BPF_MOV64_IMM(BPF_REG_0, 0),
+       BPF_EXIT_INSN(),
+       },
+       .fixup_map_hash_48b = { 4 },
+       .result = ACCEPT,
+       .prog_type = BPF_PROG_TYPE_TRACEPOINT,
+},
+{
+       "regalloc in callee",
+       .insns = {
+       BPF_MOV64_REG(BPF_REG_6, BPF_REG_1),
+       BPF_ST_MEM(BPF_DW, BPF_REG_10, -8, 0),
+       BPF_MOV64_REG(BPF_REG_2, BPF_REG_10),
+       BPF_ALU64_IMM(BPF_ADD, BPF_REG_2, -8),
+       BPF_LD_MAP_FD(BPF_REG_1, 0),
+       BPF_EMIT_CALL(BPF_FUNC_map_lookup_elem),
+       BPF_JMP_IMM(BPF_JEQ, BPF_REG_0, 0, 6),
+       BPF_MOV64_REG(BPF_REG_7, BPF_REG_0),
+       BPF_EMIT_CALL(BPF_FUNC_get_prandom_u32),
+       BPF_MOV64_REG(BPF_REG_1, BPF_REG_0),
+       BPF_MOV64_REG(BPF_REG_2, BPF_REG_0),
+       BPF_MOV64_REG(BPF_REG_3, BPF_REG_7),
+       BPF_RAW_INSN(BPF_JMP | BPF_CALL, 0, 1, 0, 1),
+       BPF_EXIT_INSN(),
+       BPF_JMP_IMM(BPF_JSGT, BPF_REG_1, 20, 5),
+       BPF_JMP_IMM(BPF_JSLT, BPF_REG_2, 0, 4),
+       BPF_ALU64_REG(BPF_ADD, BPF_REG_3, BPF_REG_1),
+       BPF_ALU64_REG(BPF_ADD, BPF_REG_3, BPF_REG_2),
+       BPF_LDX_MEM(BPF_DW, BPF_REG_0, BPF_REG_3, 0),
+       BPF_EXIT_INSN(),
+       BPF_MOV64_IMM(BPF_REG_0, 0),
+       BPF_EXIT_INSN(),
+       },
+       .fixup_map_hash_48b = { 4 },
+       .result = ACCEPT,
+       .prog_type = BPF_PROG_TYPE_TRACEPOINT,
+},
Domain: System / Kernel;