More analyzer changes (#34843)

diff --git a/src/libraries/Common/src/System/Diagnostics/NetFrameworkUtils.cs b/src/libraries/Common/src/System/Diagnostics/NetFrameworkUtils.cs
index 59d028c..de9f756 100644 (file)
--- a/src/libraries/Common/src/System/Diagnostics/NetFrameworkUtils.cs
+++ b/src/libraries/Common/src/System/Diagnostics/NetFrameworkUtils.cs
@@ -220,7 +220,7 @@ namespace System.Diagnostics
                                 StringBuilder installBuilder = new StringBuilder();
                                 installBuilder.Append(installRoot);
                                 if (!installRoot.EndsWith("\\", StringComparison.Ordinal))
-                                    installBuilder.Append("\\");
+                                    installBuilder.Append('\\');
                                 installBuilder.Append(version);
                                 dllDir = installBuilder.ToString();
                             }

diff --git a/src/libraries/Microsoft.Extensions.Configuration.Abstractions/src/ConfigurationRootExtensions.cs b/src/libraries/Microsoft.Extensions.Configuration.Abstractions/src/ConfigurationRootExtensions.cs
index e6265e3..8baf09c 100644 (file)
--- a/src/libraries/Microsoft.Extensions.Configuration.Abstractions/src/ConfigurationRootExtensions.cs
+++ b/src/libraries/Microsoft.Extensions.Configuration.Abstractions/src/ConfigurationRootExtensions.cs
@@ -33,7 +33,7 @@ namespace Microsoft.Extensions.Configuration
                         stringBuilder
                             .Append(indent)
                             .Append(child.Key)
-                            .Append("=")
+                            .Append('=')
                             .Append(valueAndProvider.Value)
                             .Append(" (")
                             .Append(valueAndProvider.Provider)

diff --git a/src/libraries/Microsoft.Extensions.DependencyInjection/src/CallSiteJsonFormatter.cs b/src/libraries/Microsoft.Extensions.DependencyInjection/src/CallSiteJsonFormatter.cs
index 68ffcbc..bd8a17f 100644 (file)
--- a/src/libraries/Microsoft.Extensions.DependencyInjection/src/CallSiteJsonFormatter.cs
+++ b/src/libraries/Microsoft.Extensions.DependencyInjection/src/CallSiteJsonFormatter.cs
@@ -146,20 +146,20 @@ namespace Microsoft.Extensions.DependencyInjection
 
             public CallSiteFormatterContext StartObject()
             {
-                Builder.Append("{");
+                Builder.Append('{');
                 return IncrementOffset();
             }
 
             public void EndObject()
             {
-                Builder.Append("}");
+                Builder.Append('}');
             }
 
             public void StartProperty(string name)
             {
                 if (!_firstItem)
                 {
-                    Builder.Append(",");
+                    Builder.Append(',');
                 }
                 else
                 {
@@ -172,7 +172,7 @@ namespace Microsoft.Extensions.DependencyInjection
             {
                 if (!_firstItem)
                 {
-                    Builder.Append(",");
+                    Builder.Append(',');
                 }
                 else
                 {
@@ -195,13 +195,13 @@ namespace Microsoft.Extensions.DependencyInjection
 
             public CallSiteFormatterContext StartArray()
             {
-                Builder.Append("[");
+                Builder.Append('[');
                 return IncrementOffset();
             }
 
             public void EndArray()
             {
-                Builder.Append("]");
+                Builder.Append(']');
             }
         }
     }

diff --git a/src/libraries/Microsoft.Extensions.Http/src/Logging/HttpHeadersLogValue.cs b/src/libraries/Microsoft.Extensions.Http/src/Logging/HttpHeadersLogValue.cs
index 8f72675..cb7213f 100644 (file)
--- a/src/libraries/Microsoft.Extensions.Http/src/Logging/HttpHeadersLogValue.cs
+++ b/src/libraries/Microsoft.Extensions.Http/src/Logging/HttpHeadersLogValue.cs
@@ -99,7 +99,7 @@ namespace Microsoft.Extensions.Http.Logging
 
                     if (_shouldRedactHeaderValue(kvp.Key))
                     {
-                        builder.Append("*");
+                        builder.Append('*');
                         builder.AppendLine();
                     }
                     else

diff --git a/src/libraries/Microsoft.Extensions.Logging.Console/src/ConsoleLogger.cs b/src/libraries/Microsoft.Extensions.Logging.Console/src/ConsoleLogger.cs
index 7be3d3d..4627136 100644 (file)
--- a/src/libraries/Microsoft.Extensions.Logging.Console/src/ConsoleLogger.cs
+++ b/src/libraries/Microsoft.Extensions.Logging.Console/src/ConsoleLogger.cs
@@ -112,7 +112,7 @@ namespace Microsoft.Extensions.Logging.Console
             // category and event id
             logBuilder.Append(_loglevelPadding);
             logBuilder.Append(logName);
-            logBuilder.Append("[");
+            logBuilder.Append('[');
             logBuilder.Append(eventId);
             logBuilder.AppendLine("]");
 
@@ -179,9 +179,9 @@ namespace Microsoft.Extensions.Logging.Console
 
             // category and event id
             logBuilder.Append(logName);
-            logBuilder.Append("[");
+            logBuilder.Append('[');
             logBuilder.Append(eventId);
-            logBuilder.Append("]");
+            logBuilder.Append(']');
 
             // scope information
             GetScopeInformation(logBuilder, multiLine: false);

diff --git a/src/libraries/Microsoft.VisualBasic.Core/src/Microsoft/VisualBasic/CompilerServices/Utils.LateBinder.vb b/src/libraries/Microsoft.VisualBasic.Core/src/Microsoft/VisualBasic/CompilerServices/Utils.LateBinder.vb
index 802ba2d..89b92b6 100644 (file)
--- a/src/libraries/Microsoft.VisualBasic.Core/src/Microsoft/VisualBasic/CompilerServices/Utils.LateBinder.vb
+++ b/src/libraries/Microsoft.VisualBasic.Core/src/Microsoft/VisualBasic/CompilerServices/Utils.LateBinder.vb
@@ -454,9 +454,9 @@ GetSpecialValue:
             '
             Do
 
-                arraySuffix.Append("(")
+                arraySuffix.Append("("c)
                 arraySuffix.Append(","c, typ.GetArrayRank() - 1)
-                arraySuffix.Append(")")
+                arraySuffix.Append(")"c)
 
                 typ = typ.GetElementType
 
@@ -495,7 +495,7 @@ GetSpecialValue:
                 End If
             Next
 
-            genericArgsSuffix.Append(")")
+            genericArgsSuffix.Append(")"c)
 
             Return genericArgsSuffix.ToString
         End Function

diff --git a/src/libraries/Microsoft.VisualBasic.Core/src/Microsoft/VisualBasic/Strings.vb b/src/libraries/Microsoft.VisualBasic.Core/src/Microsoft/VisualBasic/Strings.vb
index e481382..f34d31a 100644 (file)
--- a/src/libraries/Microsoft.VisualBasic.Core/src/Microsoft/VisualBasic/Strings.vb
+++ b/src/libraries/Microsoft.VisualBasic.Core/src/Microsoft/VisualBasic/Strings.vb
@@ -1572,7 +1572,7 @@ RedimAndExit:
                 sTmp = sb.ToString()
                 sb.Append(";(")
                 sb.Append(sTmp)
-                sb.Append(")")
+                sb.Append(")"c)
             End If
 
             Return sb.ToString()

diff --git a/src/libraries/System.Data.Odbc/src/Common/System/Data/Common/AdapterUtil.Odbc.cs b/src/libraries/System.Data.Odbc/src/Common/System/Data/Common/AdapterUtil.Odbc.cs
index aed98b8..8bf3a35 100644 (file)
--- a/src/libraries/System.Data.Odbc/src/Common/System/Data/Common/AdapterUtil.Odbc.cs
+++ b/src/libraries/System.Data.Odbc/src/Common/System/Data/Common/AdapterUtil.Odbc.cs
@@ -640,7 +640,7 @@ namespace System.Data.Common
             {
                 if (specialCharacters.IndexOf(currentChar) >= 0)
                 {
-                    escapedString.Append("\\");
+                    escapedString.Append('\\');
                 }
                 escapedString.Append(currentChar);
             }

diff --git a/src/libraries/System.Data.OleDb/src/System/Data/Common/AdapterUtil.cs b/src/libraries/System.Data.OleDb/src/System/Data/Common/AdapterUtil.cs
index 7730558..fdf8b8e 100644 (file)
--- a/src/libraries/System.Data.OleDb/src/System/Data/Common/AdapterUtil.cs
+++ b/src/libraries/System.Data.OleDb/src/System/Data/Common/AdapterUtil.cs
@@ -1018,7 +1018,7 @@ namespace System.Data.Common
             {
                 if (specialCharacters.IndexOf(currentChar) >= 0)
                 {
-                    escapedString.Append("\\");
+                    escapedString.Append('\\');
                 }
                 escapedString.Append(currentChar);
             }

diff --git a/src/libraries/System.Diagnostics.Process/src/System/Diagnostics/Process.Windows.cs b/src/libraries/System.Diagnostics.Process/src/System/Diagnostics/Process.Windows.cs
index b8a3bb1..998ec9f 100644 (file)
--- a/src/libraries/System.Diagnostics.Process/src/System/Diagnostics/Process.Windows.cs
+++ b/src/libraries/System.Diagnostics.Process/src/System/Diagnostics/Process.Windows.cs
@@ -680,14 +680,14 @@ namespace System.Diagnostics
             bool fileNameIsQuoted = (fileName.StartsWith('\"') && fileName.EndsWith('\"'));
             if (!fileNameIsQuoted)
             {
-                commandLine.Append("\"");
+                commandLine.Append('"');
             }
 
             commandLine.Append(fileName);
 
             if (!fileNameIsQuoted)
             {
-                commandLine.Append("\"");
+                commandLine.Append('"');
             }
 
             if (!string.IsNullOrEmpty(arguments))

diff --git a/src/libraries/System.Diagnostics.TextWriterTraceListener/src/System/Diagnostics/DelimitedListTraceListener.cs b/src/libraries/System.Diagnostics.TextWriterTraceListener/src/System/Diagnostics/DelimitedListTraceListener.cs
index f62a962..e077ee9 100644 (file)
--- a/src/libraries/System.Diagnostics.TextWriterTraceListener/src/System/Diagnostics/DelimitedListTraceListener.cs
+++ b/src/libraries/System.Diagnostics.TextWriterTraceListener/src/System/Diagnostics/DelimitedListTraceListener.cs
@@ -211,7 +211,7 @@ namespace System.Diagnostics
             {
                 StringBuilder sb = new StringBuilder("\"");
                 EscapeMessage(message, sb);
-                sb.Append("\"");
+                sb.Append('"');
                 Write(sb.ToString());
             }
         }
@@ -235,7 +235,7 @@ namespace System.Diagnostics
                 EscapeMessage(operation, sb);
             }
 
-            sb.Append("\"");
+            sb.Append('"');
             Write(sb.ToString());
         }
 

diff --git a/src/libraries/System.DirectoryServices.Protocols/src/System/DirectoryServices/Protocols/ldap/LdapConnection.cs b/src/libraries/System.DirectoryServices.Protocols/src/System/DirectoryServices/Protocols/ldap/LdapConnection.cs
index 7f14b88..eef1bd2 100644 (file)
--- a/src/libraries/System.DirectoryServices.Protocols/src/System/DirectoryServices/Protocols/ldap/LdapConnection.cs
+++ b/src/libraries/System.DirectoryServices.Protocols/src/System/DirectoryServices/Protocols/ldap/LdapConnection.cs
@@ -1114,7 +1114,7 @@ namespace System.DirectoryServices.Protocols
                 if (domainName != null && domainName.Length != 0)
                 {
                     tempDomainName.Append(domainName);
-                    tempDomainName.Append("\\");
+                    tempDomainName.Append('\\');
                 }
 
                 tempDomainName.Append(username);

diff --git a/src/libraries/System.Net.HttpListener/src/System/Net/Windows/HttpListenerRequest.Windows.cs b/src/libraries/System.Net.HttpListener/src/System/Net/Windows/HttpListenerRequest.Windows.cs
index 19b8975..f43558c 100644 (file)
--- a/src/libraries/System.Net.HttpListener/src/System/Net/Windows/HttpListenerRequest.Windows.cs
+++ b/src/libraries/System.Net.HttpListener/src/System/Net/Windows/HttpListenerRequest.Windows.cs
@@ -93,11 +93,11 @@ namespace System.Net
                 StringBuilder sb = new StringBuilder("HttpListenerRequest Headers:\n");
                 for (int i = 0; i < Headers.Count; i++)
                 {
-                    sb.Append("\t");
+                    sb.Append('\t');
                     sb.Append(Headers.GetKey(i));
                     sb.Append(" : ");
                     sb.Append(Headers.Get(i));
-                    sb.Append("\n");
+                    sb.Append('\n');
                 }
                 NetEventSource.Info(this, sb.ToString());
             }

diff --git a/src/libraries/System.Net.HttpListener/src/System/Net/Windows/HttpListenerResponse.Windows.cs b/src/libraries/System.Net.HttpListener/src/System/Net/Windows/HttpListenerResponse.Windows.cs
index 5e75832..233e057 100644 (file)
--- a/src/libraries/System.Net.HttpListener/src/System/Net/Windows/HttpListenerResponse.Windows.cs
+++ b/src/libraries/System.Net.HttpListener/src/System/Net/Windows/HttpListenerResponse.Windows.cs
@@ -258,11 +258,11 @@ namespace System.Net
                 StringBuilder sb = new StringBuilder("HttpListenerResponse Headers:\n");
                 for (int i = 0; i < Headers.Count; i++)
                 {
-                    sb.Append("\t");
+                    sb.Append('\t');
                     sb.Append(Headers.GetKey(i));
                     sb.Append(" : ");
                     sb.Append(Headers.Get(i));
-                    sb.Append("\n");
+                    sb.Append('\n');
                 }
                 if (NetEventSource.IsEnabled) NetEventSource.Info(this, sb.ToString());
             }

diff --git a/src/libraries/System.Private.Xml/src/System/Xml/Serialization/SchemaObjectWriter.cs b/src/libraries/System.Private.Xml/src/System/Xml/Serialization/SchemaObjectWriter.cs
index ce27742..1cd81e9 100644 (file)
--- a/src/libraries/System.Private.Xml/src/System/Xml/Serialization/SchemaObjectWriter.cs
+++ b/src/libraries/System.Private.Xml/src/System/Xml/Serialization/SchemaObjectWriter.cs
@@ -185,7 +185,7 @@ namespace System.Xml.Serialization
         {
             NewLine();
             _indentLevel++;
-            _w.Append("[");
+            _w.Append('[');
             _w.Append(name);
         }
         protected void WriteEndElement()

diff --git a/src/libraries/System.Private.Xml/src/System/Xml/Serialization/XmlSerializationWriterILGen.cs b/src/libraries/System.Private.Xml/src/System/Xml/Serialization/XmlSerializationWriterILGen.cs
index c337327..ec66d98 100644 (file)
--- a/src/libraries/System.Private.Xml/src/System/Xml/Serialization/XmlSerializationWriterILGen.cs
+++ b/src/libraries/System.Private.Xml/src/System/Xml/Serialization/XmlSerializationWriterILGen.cs
@@ -2588,7 +2588,7 @@ namespace System.Xml.Serialization
             StringBuilder writer = new StringBuilder();
             writer.Append("@\"");
             writer.Append(GetCSharpString(value));
-            writer.Append("\"");
+            writer.Append('"');
             return writer.ToString();
         }
 

diff --git a/src/libraries/System.Security.Cryptography.Xml/src/System/Security/Cryptography/Xml/CanonicalXmlAttribute.cs b/src/libraries/System.Security.Cryptography.Xml/src/System/Security/Cryptography/Xml/CanonicalXmlAttribute.cs
index 051082c..a3b0ef7 100644 (file)
--- a/src/libraries/System.Security.Cryptography.Xml/src/System/Security/Cryptography/Xml/CanonicalXmlAttribute.cs
+++ b/src/libraries/System.Security.Cryptography.Xml/src/System/Security/Cryptography/Xml/CanonicalXmlAttribute.cs
@@ -28,7 +28,7 @@ namespace System.Security.Cryptography.Xml
         {
             strBuilder.Append(" " + Name + "=\"");
             strBuilder.Append(Utils.EscapeAttributeValue(Value));
-            strBuilder.Append("\"");
+            strBuilder.Append('"');
         }
 
         public void WriteHash(HashAlgorithm hash, DocPosition docPos, AncestralNamespaceContextManager anc)