pvr: do not use fallthrough for unreachable code
authorErik Faye-Lund <erik.faye-lund@collabora.com>
Wed, 23 Mar 2022 17:34:26 +0000 (18:34 +0100)
committerMarge Bot <emma+marge@anholt.net>
Thu, 24 Mar 2022 11:25:45 +0000 (11:25 +0000)
unreachable() doesn't lead to executing the code that follows it,
neither in debug nor release builds. So falling through doesn't make any
sense.

This fixes a compile-error on clang.

Let's move the default-block to the end to make it clearer that there's
no intended fallthrough.

Reviewed-by: Frank Binns <frank.binns@imgtec.com>
Reviewed-by: Eric Engestrom <eric@engestrom.ch>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15531>

src/imagination/vulkan/pvr_cmd_buffer.c

index 889947c..76bc0f3 100644 (file)
@@ -4392,10 +4392,6 @@ static void pvr_emit_vdm_index_list(struct pvr_cmd_buffer *cmd_buffer,
          struct pvr_buffer *buffer = state->index_buffer_binding.buffer;
 
          switch (state->index_buffer_binding.type) {
-         default:
-            unreachable("Invalid index type");
-            FALLTHROUGH;
-
          case VK_INDEX_TYPE_UINT32:
             list0.index_size = PVRX(VDMCTRL_INDEX_SIZE_B32);
             index_stride = 4;
@@ -4405,6 +4401,9 @@ static void pvr_emit_vdm_index_list(struct pvr_cmd_buffer *cmd_buffer,
             list0.index_size = PVRX(VDMCTRL_INDEX_SIZE_B16);
             index_stride = 2;
             break;
+
+         default:
+            unreachable("Invalid index type");
          }
 
          list0.index_addr_present = true;