kobject: drop newline from msg string
authorBo YU <tsu.yubo@gmail.com>
Wed, 9 Jan 2019 09:17:48 +0000 (04:17 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 22 Jan 2019 13:25:26 +0000 (14:25 +0100)
There is currently a missing terminating newline in non-switch case
match when msg == NULL

Signed-off-by: Bo YU <tsu.yubo@gmail.com>
Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
lib/kobject_uevent.c

index c87a96c..f058026 100644 (file)
@@ -200,7 +200,7 @@ int kobject_synth_uevent(struct kobject *kobj, const char *buf, size_t count)
 
        r = kobject_action_type(buf, count, &action, &action_args);
        if (r) {
-               msg = "unknown uevent action string\n";
+               msg = "unknown uevent action string";
                goto out;
        }
 
@@ -212,7 +212,7 @@ int kobject_synth_uevent(struct kobject *kobj, const char *buf, size_t count)
        r = kobject_action_args(action_args,
                                count - (action_args - buf), &env);
        if (r == -EINVAL) {
-               msg = "incorrect uevent action arguments\n";
+               msg = "incorrect uevent action arguments";
                goto out;
        }
 
@@ -224,7 +224,7 @@ int kobject_synth_uevent(struct kobject *kobj, const char *buf, size_t count)
 out:
        if (r) {
                devpath = kobject_get_path(kobj, GFP_KERNEL);
-               pr_warn("synth uevent: %s: %s",
+               pr_warn("synth uevent: %s: %s\n",
                       devpath ?: "unknown device",
                       msg ?: "failed to send uevent");
                kfree(devpath);