Fixed linting on Windows
authorTereza Tomcova <tereza.tomcova@gmail.com>
Fri, 18 Nov 2016 20:50:53 +0000 (21:50 +0100)
committerTereza Tomcova <tereza.tomcova@gmail.com>
Wed, 23 Nov 2016 07:18:46 +0000 (08:18 +0100)
package.json
script/pylint.py

index e533a3e..5114f53 100644 (file)
@@ -4,6 +4,7 @@
   "devDependencies": {
     "asar": "^0.11.0",
     "browserify": "^13.1.0",
+    "cross-conf-env": "^1.0.6",
     "electabul": "~0.0.4",
     "electron-docs-linter": "^1.16.0",
     "request": "*",
@@ -37,7 +38,7 @@
     "lint-cpp": "python ./script/cpplint.py",
     "lint-py": "python ./script/pylint.py",
     "lint-api-docs-js": "standard-markdown docs && standard-markdown docs-translations",
-    "lint-api-docs": "electron-docs-linter docs/api --version=$npm_package_version --outfile=out/electron-api.json",
+    "lint-api-docs": "cross-conf-env electron-docs-linter docs/api --version=$npm_package_version --outfile=out/electron-api.json",
     "preinstall": "node -e 'process.exit(0)'",
     "release": "./script/upload.py -p",
     "repl": "python ./script/start.py --interactive",
index 4aba391..a4cb7fd 100755 (executable)
@@ -14,8 +14,9 @@ def main():
   pylint = os.path.join(SOURCE_ROOT, 'vendor', 'depot_tools', 'pylint.py')
   settings = ['--rcfile=vendor/depot_tools/pylintrc']
   pys = glob.glob('script/*.py')
-  subprocess.check_call([sys.executable, pylint] + settings + pys,
-                        env=dict(PYTHONPATH='script'))
+  env = os.environ.copy()
+  env['PYTHONPATH'] = 'script'
+  subprocess.check_call([sys.executable, pylint] + settings + pys, env=env)
 
 
 if __name__ == '__main__':