KVM: SVM: Don't advertise Bus Lock Detect to guest if SVM support is missing
authorRavi Bangoria <ravi.bangoria@amd.com>
Thu, 8 Aug 2024 06:29:36 +0000 (06:29 +0000)
committerSean Christopherson <seanjc@google.com>
Thu, 22 Aug 2024 19:17:44 +0000 (12:17 -0700)
If host supports Bus Lock Detect, KVM advertises it to guests even if
SVM support is absent. Additionally, guest wouldn't be able to use it
despite guest CPUID bit being set. Fix it by unconditionally clearing
the feature bit in KVM cpu capability.

Reported-by: Jim Mattson <jmattson@google.com>
Closes: https://lore.kernel.org/r/CALMp9eRet6+v8Y1Q-i6mqPm4hUow_kJNhmVHfOV8tMfuSS=tVg@mail.gmail.com
Fixes: 76ea438b4afc ("KVM: X86: Expose bus lock debug exception to guest")
Cc: stable@vger.kernel.org
Signed-off-by: Ravi Bangoria <ravi.bangoria@amd.com>
Reviewed-by: Jim Mattson <jmattson@google.com>
Reviewed-by: Tom Lendacky <thomas.lendacky@amd.com>
Link: https://lore.kernel.org/r/20240808062937.1149-4-ravi.bangoria@amd.com
Signed-off-by: Sean Christopherson <seanjc@google.com>
arch/x86/kvm/svm/svm.c

index b11454151f252f1acc3efc15f7bfcbdf2e402a4a..5ab2c92c7331deba414de1077b3ea0eb58920d66 100644 (file)
@@ -5236,6 +5236,9 @@ static __init void svm_set_cpu_caps(void)
 
        /* CPUID 0x8000001F (SME/SEV features) */
        sev_set_cpu_caps();
+
+       /* Don't advertise Bus Lock Detect to guest if SVM support is absent */
+       kvm_cpu_cap_clear(X86_FEATURE_BUS_LOCK_DETECT);
 }
 
 static __init int svm_hardware_setup(void)