scsi: target: core: Add initiatorname to NON_EXISTENT_LUN error
authorLance Digby <lance.digby@gmail.com>
Mon, 18 May 2020 01:02:16 +0000 (11:02 +1000)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 20 May 2020 01:27:10 +0000 (21:27 -0400)
The NON_EXISTENT_LUN error can be written without an error condition
on the initiator responsible. Adding the initiatorname to this message
will reduce the effort required to fix this when many initiators are
supported by a target.

This version ensures the initiator name is also printed on the same message
in transport_lookup_tmr_lun for consistency.

Link: https://lore.kernel.org/r/9b13bb2e1f52f1792cd81850ee95bf3781bb5363.1589759816.git.lance.digby@gmail.com
Reviewed-by: Mike Christie <mchristi@redhat.com>
Signed-off-by: Lance Digby <lance.digby@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/target/target_core_device.c

index d5800cf..46b0e1c 100644 (file)
@@ -100,9 +100,10 @@ out_unlock:
                 */
                if (unpacked_lun != 0) {
                        pr_err("TARGET_CORE[%s]: Detected NON_EXISTENT_LUN"
-                               " Access for 0x%08llx\n",
+                               " Access for 0x%08llx from %s\n",
                                se_cmd->se_tfo->fabric_name,
-                               unpacked_lun);
+                               unpacked_lun,
+                               nacl->initiatorname);
                        return TCM_NON_EXISTENT_LUN;
                }
 
@@ -174,9 +175,10 @@ out_unlock:
 
        if (!se_lun) {
                pr_debug("TARGET_CORE[%s]: Detected NON_EXISTENT_LUN"
-                       " Access for 0x%08llx\n",
+                       " Access for 0x%08llx for %s\n",
                        se_cmd->se_tfo->fabric_name,
-                       unpacked_lun);
+                       unpacked_lun,
+                       nacl->initiatorname);
                return -ENODEV;
        }
        se_cmd->se_dev = rcu_dereference_raw(se_lun->lun_se_dev);