net: ipa: HOL_BLOCK_EN_FMASK is a 1-bit mask
authorAlex Elder <elder@linaro.org>
Tue, 30 Jun 2020 13:33:04 +0000 (08:33 -0500)
committerDavid S. Miller <davem@davemloft.net>
Wed, 1 Jul 2020 22:30:34 +0000 (15:30 -0700)
The convention throughout the IPA driver is to directly use
single-bit field mask values, rather than using (for example)
u32_encode_bits() to set or clear them.

Fix the one place that doesn't follow that convention, which sets
HOL_BLOCK_EN_FMASK in ipa_endpoint_init_hol_block_enable().

Signed-off-by: Alex Elder <elder@linaro.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ipa/ipa_endpoint.c

index eab8409a8be98b8b03ceb5fe135a7d29053280b6..a7b5a6407e8fbc7dda87217e212abb2e4d4d20fa 100644 (file)
@@ -674,7 +674,7 @@ ipa_endpoint_init_hol_block_enable(struct ipa_endpoint *endpoint, bool enable)
        u32 offset;
        u32 val;
 
-       val = u32_encode_bits(enable ? 1 : 0, HOL_BLOCK_EN_FMASK);
+       val = enable ? HOL_BLOCK_EN_FMASK : 0;
        offset = IPA_REG_ENDP_INIT_HOL_BLOCK_EN_N_OFFSET(endpoint_id);
        iowrite32(val, endpoint->ipa->reg_virt + offset);
 }