mm, percpu: Make sure percpu_alloc early parameter has an argument
authorCyrill Gorcunov <gorcunov@openvz.org>
Sat, 24 Nov 2012 21:17:13 +0000 (01:17 +0400)
committerTejun Heo <tj@kernel.org>
Sun, 2 Dec 2012 14:23:04 +0000 (06:23 -0800)
Otherwise we are getting a nil dereference if percpu_alloc kernel boot
argument is specified without value.

 | [    0.000000] BUG: unable to handle kernel NULL pointer dereference at           (null)
 | [    0.000000] IP: [<ffffffff81391360>] strcmp+0x10/0x30

Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
Signed-off-by: Tejun Heo <tj@kernel.org>
mm/percpu.c

index ec25896..8c8e08f 100644 (file)
@@ -1380,6 +1380,9 @@ enum pcpu_fc pcpu_chosen_fc __initdata = PCPU_FC_AUTO;
 
 static int __init percpu_alloc_setup(char *str)
 {
+       if (!str)
+               return -EINVAL;
+
        if (0)
                /* nada */;
 #ifdef CONFIG_NEED_PER_CPU_EMBED_FIRST_CHUNK