ges: Ensure GObject finalize and dispose methods chain up to parents
authorDan Williams <dcbw@redhat.com>
Fri, 7 Mar 2014 20:48:06 +0000 (14:48 -0600)
committerTim-Philipp Müller <tim@centricular.com>
Sat, 8 Mar 2014 11:24:33 +0000 (11:24 +0000)
https://bugzilla.gnome.org/show_bug.cgi?id=725918

ges/ges-clip-asset.c
ges/ges-container.c
ges/ges-formatter.c
ges/ges-project.c
ges/gstframepositionner.c

index 1ebe26e..cf3fdcd 100644 (file)
@@ -55,15 +55,6 @@ static GParamSpec *properties[PROP_LAST];
  *      GObject vmetods implemenation          *
  *                                             *
  ***********************************************/
-static void
-_dispose (GObject * object)
-{
-}
-
-static void
-_finalize (GObject * object)
-{
-}
 
 static void
 _get_property (GObject * object, guint property_id,
@@ -123,8 +114,6 @@ ges_clip_asset_class_init (GESClipAssetClass * self_class)
 
   g_type_class_add_private (self_class, sizeof (GESClipAssetPrivate));
   object_class->constructed = _constructed;
-  object_class->dispose = _dispose;
-  object_class->finalize = _finalize;
   object_class->get_property = _get_property;
   object_class->set_property = _set_property;
 
index 8c3d9c4..68e3680 100644 (file)
@@ -196,6 +196,8 @@ _dispose (GObject * object)
   GESContainer *self = GES_CONTAINER (object);
 
   g_hash_table_unref (self->priv->mappings);
+
+  G_OBJECT_CLASS (ges_container_parent_class)->dispose (object);
 }
 
 static void
index 2ba3cf1..aab6e16 100644 (file)
@@ -140,6 +140,8 @@ static void
 ges_formatter_dispose (GObject * object)
 {
   ges_formatter_set_project (GES_FORMATTER (object), NULL);
+
+  G_OBJECT_CLASS (ges_formatter_parent_class)->dispose (object);
 }
 
 static gboolean
index 5c95ca8..dfb2497 100644 (file)
@@ -273,6 +273,8 @@ _finalize (GObject * object)
 
   if (priv->uri)
     g_free (priv->uri);
+
+  G_OBJECT_CLASS (ges_project_parent_class)->finalize (object);
 }
 
 static void
index ae75bcd..b9cfeb6 100644 (file)
@@ -226,6 +226,8 @@ gst_frame_positionner_dispose (GObject * object)
         (GWeakNotify) _weak_notify_cb, pos);
     pos->current_track = NULL;
   }
+
+  G_OBJECT_CLASS (gst_frame_positionner_parent_class)->dispose (object);
 }
 
 static void