projects
/
platform
/
kernel
/
linux-starfive.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
57b0c96
)
Input: rpckbd - fix the return value handle for platform_get_irq()
author
Ruan Jinjie
<ruanjinjie@huawei.com>
Tue, 1 Aug 2023 23:44:52 +0000
(16:44 -0700)
committer
Dmitry Torokhov
<dmitry.torokhov@gmail.com>
Tue, 1 Aug 2023 23:47:39 +0000
(16:47 -0700)
There is no possible for platform_get_irq() to return 0,
and the return value of platform_get_irq() is more sensible
to show the error reason.
Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
Link:
https://lore.kernel.org/r/20230731122246.2028651-1-ruanjinjie@huawei.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/serio/rpckbd.c
patch
|
blob
|
history
diff --git
a/drivers/input/serio/rpckbd.c
b/drivers/input/serio/rpckbd.c
index
ce420eb
..
e8a9709
100644
(file)
--- a/
drivers/input/serio/rpckbd.c
+++ b/
drivers/input/serio/rpckbd.c
@@
-101,12
+101,12
@@
static int rpckbd_probe(struct platform_device *dev)
int tx_irq, rx_irq;
rx_irq = platform_get_irq(dev, 0);
- if (rx_irq <
=
0)
- return rx_irq
< 0 ? rx_irq : -ENXIO
;
+ if (rx_irq < 0)
+ return rx_irq;
tx_irq = platform_get_irq(dev, 1);
- if (tx_irq <
=
0)
- return tx_irq
< 0 ? tx_irq : -ENXIO
;
+ if (tx_irq < 0)
+ return tx_irq;
serio = kzalloc(sizeof(struct serio), GFP_KERNEL);
rpckbd = kzalloc(sizeof(*rpckbd), GFP_KERNEL);