usb: gadget: net2272: remove redundant initialization of status
authorColin Ian King <colin.king@canonical.com>
Tue, 20 Apr 2021 11:06:22 +0000 (12:06 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 22 Apr 2021 08:52:15 +0000 (10:52 +0200)
The variable status is being initialized with a value that is
never read and it is being updated later with a new value.  The
initialization is redundant and can be removed and move the
declaration of status to the scope where it is used.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Addresses-Coverity: ("Unused value")
Link: https://lore.kernel.org/r/20210420110622.377339-1-colin.king@canonical.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/gadget/udc/net2272.c

index 23a7356..89f479b 100644 (file)
@@ -539,7 +539,6 @@ net2272_read_fifo(struct net2272_ep *ep, struct net2272_request *req)
        int count;
        int tmp;
        int cleanup = 0;
-       int status = -1;
 
        dev_vdbg(ep->dev->dev, "read_fifo %s actual %d len %d\n",
                ep->ep.name, req->req.actual, req->req.length);
@@ -591,6 +590,8 @@ net2272_read_fifo(struct net2272_ep *ep, struct net2272_request *req)
                        }
 
                        if (!list_empty(&ep->queue)) {
+                               int status;
+
                                req = list_entry(ep->queue.next,
                                        struct net2272_request, queue);
                                status = net2272_kick_dma(ep, req);