pinctrl: qcom: fix wrong pull status display for no_keeper SoC
authorClément Péron <peron.clem@gmail.com>
Fri, 4 May 2018 23:57:28 +0000 (16:57 -0700)
committerLinus Walleij <linus.walleij@linaro.org>
Wed, 16 May 2018 12:52:03 +0000 (14:52 +0200)
DebugFS strings about pin pull status for no_keeper SoC are wrong

Fix this by adding a different string array for no_keeper SoC

Signed-off-by: Clément Péron <peron.clem@gmail.com>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/qcom/pinctrl-msm.c

index fa4e94f..c3c77b8 100644 (file)
@@ -504,13 +504,19 @@ static void msm_gpio_dbg_show_one(struct seq_file *s,
        int pull;
        u32 ctl_reg;
 
-       static const char * const pulls[] = {
+       static const char * const pulls_keeper[] = {
                "no pull",
                "pull down",
                "keeper",
                "pull up"
        };
 
+       static const char * const pulls_no_keeper[] = {
+               "no pull",
+               "pull down",
+               "pull up",
+       };
+
        if (!gpiochip_line_is_valid(chip, offset))
                return;
 
@@ -524,7 +530,10 @@ static void msm_gpio_dbg_show_one(struct seq_file *s,
 
        seq_printf(s, " %-8s: %-3s %d", g->name, is_out ? "out" : "in", func);
        seq_printf(s, " %dmA", msm_regval_to_drive(drive));
-       seq_printf(s, " %s", pulls[pull]);
+       if (pctrl->soc->pull_no_keeper)
+               seq_printf(s, " %s", pulls_no_keeper[pull]);
+       else
+               seq_printf(s, " %s", pulls_keeper[pull]);
        seq_puts(s, "\n");
 }