ath5k: remove debug_dump_skb() functions
authorBob Copeland <me@bobcopeland.com>
Tue, 25 Jan 2011 04:32:56 +0000 (23:32 -0500)
committerJohn W. Linville <linville@tuxdriver.com>
Fri, 28 Jan 2011 20:44:27 +0000 (15:44 -0500)
Now that rx and tx dumps go through the tracing infrastructure,
we no longer need to keep these routines around.

Signed-off-by: Bob Copeland <me@bobcopeland.com>
Acked-by: Bruno Randolf <br1@einfach.org>
Acked-by: Nick Kossifidis <mickflemm@gmail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/ath/ath5k/debug.c
drivers/net/wireless/ath/ath5k/debug.h

index d2f84d7..0230f30 100644 (file)
@@ -308,8 +308,6 @@ static const struct {
        { ATH5K_DEBUG_CALIBRATE, "calib",       "periodic calibration" },
        { ATH5K_DEBUG_TXPOWER,  "txpower",      "transmit power setting" },
        { ATH5K_DEBUG_LED,      "led",          "LED management" },
-       { ATH5K_DEBUG_DUMP_RX,  "dumprx",       "print received skb content" },
-       { ATH5K_DEBUG_DUMP_TX,  "dumptx",       "print transmit skb content" },
        { ATH5K_DEBUG_DUMPBANDS, "dumpbands",   "dump bands" },
        { ATH5K_DEBUG_DMA,      "dma",          "dma start/stop" },
        { ATH5K_DEBUG_ANI,      "ani",          "adaptive noise immunity" },
@@ -1036,24 +1034,6 @@ ath5k_debug_printrxbuffs(struct ath5k_softc *sc, struct ath5k_hw *ah)
 }
 
 void
-ath5k_debug_dump_skb(struct ath5k_softc *sc,
-                       struct sk_buff *skb, const char *prefix, int tx)
-{
-       char buf[16];
-
-       if (likely(!((tx && (sc->debug.level & ATH5K_DEBUG_DUMP_TX)) ||
-                    (!tx && (sc->debug.level & ATH5K_DEBUG_DUMP_RX)))))
-               return;
-
-       snprintf(buf, sizeof(buf), "%s %s", wiphy_name(sc->hw->wiphy), prefix);
-
-       print_hex_dump_bytes(buf, DUMP_PREFIX_NONE, skb->data,
-               min(200U, skb->len));
-
-       printk(KERN_DEBUG "\n");
-}
-
-void
 ath5k_debug_printtxbuf(struct ath5k_softc *sc, struct ath5k_buf *bf)
 {
        struct ath5k_desc *ds = bf->desc;
index 3e34428..b0355ae 100644 (file)
@@ -116,8 +116,6 @@ enum ath5k_debug_level {
        ATH5K_DEBUG_CALIBRATE   = 0x00000020,
        ATH5K_DEBUG_TXPOWER     = 0x00000040,
        ATH5K_DEBUG_LED         = 0x00000080,
-       ATH5K_DEBUG_DUMP_RX     = 0x00000100,
-       ATH5K_DEBUG_DUMP_TX     = 0x00000200,
        ATH5K_DEBUG_DUMPBANDS   = 0x00000400,
        ATH5K_DEBUG_DMA         = 0x00000800,
        ATH5K_DEBUG_ANI         = 0x00002000,
@@ -152,10 +150,6 @@ void
 ath5k_debug_dump_bands(struct ath5k_softc *sc);
 
 void
-ath5k_debug_dump_skb(struct ath5k_softc *sc,
-                       struct sk_buff *skb, const char *prefix, int tx);
-
-void
 ath5k_debug_printtxbuf(struct ath5k_softc *sc, struct ath5k_buf *bf);
 
 #else /* no debugging */
@@ -182,10 +176,6 @@ static inline void
 ath5k_debug_dump_bands(struct ath5k_softc *sc) {}
 
 static inline void
-ath5k_debug_dump_skb(struct ath5k_softc *sc,
-                       struct sk_buff *skb, const char *prefix, int tx) {}
-
-static inline void
 ath5k_debug_printtxbuf(struct ath5k_softc *sc, struct ath5k_buf *bf) {}
 
 #endif /* ifdef CONFIG_ATH5K_DEBUG */