mac80211: remove unused argument to ieee80211_sta_connection_lost()
authorJohannes Berg <johannes.berg@intel.com>
Fri, 13 May 2022 15:46:23 +0000 (17:46 +0200)
committerJohannes Berg <johannes.berg@intel.com>
Mon, 16 May 2022 07:15:04 +0000 (09:15 +0200)
We never use the bssid argument to ieee80211_sta_connection_lost()
so we might as well just remove it.

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
net/mac80211/ieee80211_i.h
net/mac80211/main.c
net/mac80211/mlme.c

index e58aa6f..d072f20 100644 (file)
@@ -1859,7 +1859,7 @@ void ieee80211_mgd_quiesce(struct ieee80211_sub_if_data *sdata);
 void ieee80211_sta_restart(struct ieee80211_sub_if_data *sdata);
 void ieee80211_sta_handle_tspec_ac_params(struct ieee80211_sub_if_data *sdata);
 void ieee80211_sta_connection_lost(struct ieee80211_sub_if_data *sdata,
-                                  u8 *bssid, u8 reason, bool tx);
+                                  u8 reason, bool tx);
 
 /* IBSS code */
 void ieee80211_ibss_notify_scan_completed(struct ieee80211_local *local);
index 03f772c..5a385d4 100644 (file)
@@ -287,8 +287,8 @@ static void ieee80211_restart_work(struct work_struct *work)
                        if (sdata->vif.csa_active) {
                                sdata_lock(sdata);
                                ieee80211_sta_connection_lost(sdata,
-                                                             sdata->u.mgd.bssid,
-                                                             WLAN_REASON_UNSPECIFIED, false);
+                                                             WLAN_REASON_UNSPECIFIED,
+                                                             false);
                                sdata_unlock(sdata);
                        }
                }
index b3ad1df..116d7c5 100644 (file)
@@ -4503,7 +4503,7 @@ static void ieee80211_sta_timer(struct timer_list *t)
 }
 
 void ieee80211_sta_connection_lost(struct ieee80211_sub_if_data *sdata,
-                                  u8 *bssid, u8 reason, bool tx)
+                                  u8 reason, bool tx)
 {
        u8 frame_buf[IEEE80211_DEAUTH_FRAME_LEN];
 
@@ -4758,7 +4758,7 @@ void ieee80211_sta_work(struct ieee80211_sub_if_data *sdata)
                                mlme_dbg(sdata,
                                         "No ack for nullfunc frame to AP %pM, disconnecting.\n",
                                         bssid);
-                               ieee80211_sta_connection_lost(sdata, bssid,
+                               ieee80211_sta_connection_lost(sdata,
                                        WLAN_REASON_DISASSOC_DUE_TO_INACTIVITY,
                                        false);
                        }
@@ -4768,7 +4768,7 @@ void ieee80211_sta_work(struct ieee80211_sub_if_data *sdata)
                        mlme_dbg(sdata,
                                 "Failed to send nullfunc to AP %pM after %dms, disconnecting\n",
                                 bssid, probe_wait_ms);
-                       ieee80211_sta_connection_lost(sdata, bssid,
+                       ieee80211_sta_connection_lost(sdata,
                                WLAN_REASON_DISASSOC_DUE_TO_INACTIVITY, false);
                } else if (ifmgd->probe_send_count < max_tries) {
                        mlme_dbg(sdata,
@@ -4785,7 +4785,7 @@ void ieee80211_sta_work(struct ieee80211_sub_if_data *sdata)
                                 "No probe response from AP %pM after %dms, disconnecting.\n",
                                 bssid, probe_wait_ms);
 
-                       ieee80211_sta_connection_lost(sdata, bssid,
+                       ieee80211_sta_connection_lost(sdata,
                                WLAN_REASON_DISASSOC_DUE_TO_INACTIVITY, false);
                }
        }
@@ -4940,7 +4940,6 @@ void ieee80211_sta_restart(struct ieee80211_sub_if_data *sdata)
                sdata->flags &= ~IEEE80211_SDATA_DISCONNECT_RESUME;
                mlme_dbg(sdata, "driver requested disconnect after resume\n");
                ieee80211_sta_connection_lost(sdata,
-                                             ifmgd->bssid,
                                              WLAN_REASON_UNSPECIFIED,
                                              true);
                sdata_unlock(sdata);
@@ -4951,7 +4950,6 @@ void ieee80211_sta_restart(struct ieee80211_sub_if_data *sdata)
                sdata->flags &= ~IEEE80211_SDATA_DISCONNECT_HW_RESTART;
                mlme_dbg(sdata, "driver requested disconnect after hardware restart\n");
                ieee80211_sta_connection_lost(sdata,
-                                             ifmgd->bssid,
                                              WLAN_REASON_UNSPECIFIED,
                                              true);
                sdata_unlock(sdata);