NFSD: Replace READ* macros in nfsd4_decode_secinfo_no_name()
authorChuck Lever <chuck.lever@oracle.com>
Tue, 3 Nov 2020 19:33:12 +0000 (14:33 -0500)
committerChuck Lever <chuck.lever@oracle.com>
Mon, 30 Nov 2020 19:46:42 +0000 (14:46 -0500)
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
fs/nfsd/nfs4xdr.c

index 4a4cf3e..2a738af 100644 (file)
@@ -1357,17 +1357,6 @@ nfsd4_decode_secinfo(struct nfsd4_compoundargs *argp,
 }
 
 static __be32
-nfsd4_decode_secinfo_no_name(struct nfsd4_compoundargs *argp,
-                    struct nfsd4_secinfo_no_name *sin)
-{
-       DECODE_HEAD;
-
-       READ_BUF(4);
-       sin->sin_style = be32_to_cpup(p++);
-       DECODE_TAIL;
-}
-
-static __be32
 nfsd4_decode_setattr(struct nfsd4_compoundargs *argp, struct nfsd4_setattr *setattr)
 {
        __be32 status;
@@ -1918,6 +1907,14 @@ nfsd4_decode_layoutreturn(struct nfsd4_compoundargs *argp,
 }
 #endif /* CONFIG_NFSD_PNFS */
 
+static __be32 nfsd4_decode_secinfo_no_name(struct nfsd4_compoundargs *argp,
+                                          struct nfsd4_secinfo_no_name *sin)
+{
+       if (xdr_stream_decode_u32(argp->xdr, &sin->sin_style) < 0)
+               return nfserr_bad_xdr;
+       return nfs_ok;
+}
+
 static __be32
 nfsd4_decode_fallocate(struct nfsd4_compoundargs *argp,
                       struct nfsd4_fallocate *fallocate)