Evas gesture: do not use abs when dealing with double, use fabs instead
authorVincent Torri <vincent.torri@gmail.com>
Mon, 27 May 2019 06:56:41 +0000 (15:56 +0900)
committerJunsuChoi <jsuya.choi@samsung.com>
Thu, 30 May 2019 08:17:53 +0000 (17:17 +0900)
Summary: clang reports a warning here. We compare the result of abs (casting to an int, returning an int) to a double value. Hence we should use fabs instead

Test Plan: compilation

Reviewers: Jaehyun, Hermet

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9024

src/lib/evas/gesture/efl_canvas_gesture_recognizer_momentum.c

index 34c9030..2e007cc 100644 (file)
@@ -175,8 +175,8 @@ _efl_canvas_gesture_recognizer_momentum_efl_canvas_gesture_recognizer_recognize(
                   pd->t_end = efl_gesture_touch_cur_timestamp_get(event);
            efl_gesture_hotspot_set(gesture, pd->end_line);
 
-           if ((abs(md->momentum.x) > EFL_GESTURE_MINIMUM_MOMENTUM) ||
-               (abs(md->momentum.y) > EFL_GESTURE_MINIMUM_MOMENTUM))
+           if ((fabs(md->momentum.x) > EFL_GESTURE_MINIMUM_MOMENTUM) ||
+               (fabs(md->momentum.y) > EFL_GESTURE_MINIMUM_MOMENTUM))
                 result = EFL_GESTURE_FINISH;
            else
                 result = EFL_GESTURE_CANCEL;