[Utils/Log] Fix syntax/semantic errors for log functions in ne-utils.c

This commit fixes some syntax/semantic errors in ne-utils.c

Signed-off-by: Dongju Chae <dongju.chae@samsung.com>

diff --git a/core/npu-engine/src/ne-utils.c b/core/npu-engine/src/ne-utils.c
index 0c78c2a..fae0194 100644 (file)
--- a/core/npu-engine/src/ne-utils.c
+++ b/core/npu-engine/src/ne-utils.c
@@ -13,7 +13,10 @@
 
 #include <ne-utils.h>
 #include <assert.h>
+#include <stdio.h>
 #include <stdlib.h>
+#include <string.h>
+#include <stdarg.h>
 #include <time.h>
 #include "ne-conf.h"
 
@@ -269,25 +272,25 @@ static const char *modulestr[] = {
   [_N72] = "N72/IOMM",
 };
 
+static FILE *fp = NULL;
+
 /**
  * @brief Write a log, to a logfile designated by conf
  * @param[in] l Loglevel
  * @param[in] m Module designation
  */
 void logwrite(loglevel l, module m, const char *format, ...) {
-  static FILE *fp = NULL;
-
+  va_list args;
   time_t ltime;
+  char* time_str;
+ 
   ltime = time(NULL);
 
-  va_list args;
-
   if (fp == NULL) {
     size_t n = strlen(conf->log_dir) + strlen(logfilename);
     char *filename = malloc(n + 1);
-    FILE *fp;
 
-    strncpy(filename, conf->log_dir, strlen(conf->log_dir);
+    strncpy(filename, conf->log_dir, strlen(conf->log_dir));
     strncat(filename, logfilename, n);
 
     fp = fopen(filename, "a");
@@ -295,9 +298,13 @@ void logwrite(loglevel l, module m, const char *format, ...) {
 
   assert(fp != NULL);
 
+  /* asctime() generates a new line; so remove it */
+  time_str = asctime(localtime(&ltime));
+  time_str[strlen(time_str) - 1] = '\x00';
+  fprintf(fp, "[%s][%s][%s] ", loglevelstr[l], modulestr[m], time_str);
+
   va_start (args, format);
-  fprintf(fp, "[%s][%s][%s] " format, loglevelstr[l], modulestr[m],
-      asctime(localtime(&ltime)), args);
+  vfprintf(fp, format, args);
   va_end (args);
 }