net_sched: remove impossible conditions
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 25 Aug 2022 13:25:08 +0000 (16:25 +0300)
committerJakub Kicinski <kuba@kernel.org>
Sat, 27 Aug 2022 02:48:19 +0000 (19:48 -0700)
We no longer allow "handle" to be zero, so there is no need to check
for that.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/Ywd4NIoS4aiilnMv@kili
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/sched/cls_route.c

index 48712bc..29adac7 100644 (file)
@@ -488,7 +488,7 @@ static int route4_change(struct net *net, struct sk_buff *in_skb,
        }
 
        if (opt == NULL)
-               return handle ? -EINVAL : 0;
+               return -EINVAL;
 
        err = nla_parse_nested_deprecated(tb, TCA_ROUTE4_MAX, opt,
                                          route4_policy, NULL);
@@ -496,7 +496,7 @@ static int route4_change(struct net *net, struct sk_buff *in_skb,
                return err;
 
        fold = *arg;
-       if (fold && handle && fold->handle != handle)
+       if (fold && fold->handle != handle)
                        return -EINVAL;
 
        err = -ENOBUFS;