cfg80211: remove struct ieee80211_he_bss_color
authorJohannes Berg <johannes.berg@intel.com>
Sun, 6 Dec 2020 12:54:40 +0000 (14:54 +0200)
committerJohannes Berg <johannes.berg@intel.com>
Fri, 11 Dec 2020 12:20:04 +0000 (13:20 +0100)
We don't really use this struct, we're now using
struct cfg80211_he_bss_color instead.

Change the one place in mac80211 that's using the old
name to use struct assignment instead of memcpy() and
thus remove the wrong sizeof while at it.

Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
Link: https://lore.kernel.org/r/iwlwifi.20201206145305.f6698d97ae4e.Iba2dffcb79c4ab80bde7407609806010b55edfdf@changeid
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
include/net/cfg80211.h
net/mac80211/cfg.c

index d9b67ee..1a79d6b 100644 (file)
@@ -303,19 +303,6 @@ struct cfg80211_he_bss_color {
 };
 
 /**
- * struct ieee80211_he_bss_color - AP settings for BSS coloring
- *
- * @color: the current color.
- * @disabled: is the feature disabled.
- * @partial: define the AID equation.
- */
-struct ieee80211_he_bss_color {
-       u8 color;
-       bool disabled;
-       bool partial;
-};
-
-/**
  * struct ieee80211_sta_ht_cap - STA's HT capabilities
  *
  * This structure describes most essential parameters needed
index 7da343e..1344ce2 100644 (file)
@@ -1124,8 +1124,7 @@ static int ieee80211_start_ap(struct wiphy *wiphy, struct net_device *dev,
        sdata->vif.bss_conf.twt_responder = params->twt_responder;
        memcpy(&sdata->vif.bss_conf.he_obss_pd, &params->he_obss_pd,
               sizeof(struct ieee80211_he_obss_pd));
-       memcpy(&sdata->vif.bss_conf.he_bss_color, &params->he_bss_color,
-              sizeof(struct ieee80211_he_bss_color));
+       sdata->vif.bss_conf.he_bss_color = params->he_bss_color;
        sdata->vif.bss_conf.s1g = params->chandef.chan->band ==
                                  NL80211_BAND_S1GHZ;