ecore/ecore_fb: Disable mouse move event filtering.
authorantognolli <antognolli@7cbeb6ba-43b4-40fd-8cce-4c39aea84d33>
Thu, 27 Oct 2011 18:57:23 +0000 (18:57 +0000)
committerantognolli <antognolli@7cbeb6ba-43b4-40fd-8cce-4c39aea84d33>
Thu, 27 Oct 2011 18:57:23 +0000 (18:57 +0000)
There are two main reasons for disabling this now:
 - it's not working, some problem with an assertion of ecore_lock is
 making the program abort;
 - it's wrong, mouse move events can only be filtered out if they are
 received from an absolute axis device (touchscreen and so), not
 relative ones, like mouse or touchpads.
Patch for SiT.

git-svn-id: http://svn.enlightenment.org/svn/e/trunk/ecore@64444 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

src/lib/ecore_fb/ecore_fb_vt.c

index 3d76f14..20c3f18 100644 (file)
@@ -131,7 +131,9 @@ _ecore_fb_vt_setup(void)
                                                     _ecore_fb_signal_usr_handler,
                                                     NULL);
    /* What does this do? */
+   /*
    _ecore_fb_filter_handler = ecore_event_filter_add(_ecore_fb_event_filter_start, _ecore_fb_event_filter_filter, _ecore_fb_event_filter_end, NULL);
+   */
 
    usleep(40000);
    if (ioctl(_ecore_fb_vt_tty_fd, VT_ACTIVATE, _ecore_fb_vt_current_vt) < 0)
@@ -269,6 +271,12 @@ ecore_fb_callback_lose_set(void (*func) (void *data), void *data)
  * @}
  */
 
+/*
+ * This filter should take into account that the MOUSE_MOVE event can be
+ * triggered by a mouse, not just a touchscreen device, so you can't discard
+ * them (only those generated by a device that sends events with absolute
+ * coordinates).
+
 typedef struct _Ecore_Fb_Filter_Data Ecore_Fb_Filter_Data;
 
 struct _Ecore_Fb_Filter_Data
@@ -312,3 +320,4 @@ _ecore_fb_event_filter_end(void *data __UNUSED__, void *loop_data)
    filter_data = loop_data;
    if (filter_data) free(filter_data);
 }
+*/