i2c: eg20t: Drop PCI wakeup calls from .suspend/.resume
authorVaibhav Gupta <vaibhavgupta40@gmail.com>
Wed, 5 Aug 2020 19:36:15 +0000 (01:06 +0530)
committerWolfram Sang <wsa@kernel.org>
Mon, 10 Aug 2020 13:46:31 +0000 (15:46 +0200)
The driver calls pci_enable_wake(...., false) in pch_i2c_suspend() as well
as pch_i2c_resume(). Either it should enable-wake the device in .suspend()
or should not invoke pci_enable_wake() at all.

Concluding that this driver doesn't support enable-wake and PCI core calls
pci_enable_wake(pci_dev, PCI_D0, false) during resume, drop it from
.suspend() and .resume().

Reported-by: Bjorn Helgaas <helgaas@kernel.org>
Signed-off-by: Vaibhav Gupta <vaibhavgupta40@gmail.com>
Reviewed-by: Bjorn Helgaas <bhelgaas@google.com>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
drivers/i2c/busses/i2c-eg20t.c

index 73f1396..eb41de2 100644 (file)
@@ -879,7 +879,6 @@ static int pch_i2c_suspend(struct pci_dev *pdev, pm_message_t state)
                return ret;
        }
 
-       pci_enable_wake(pdev, PCI_D3hot, 0);
        pci_disable_device(pdev);
        pci_set_power_state(pdev, pci_choose_state(pdev, state));
 
@@ -899,8 +898,6 @@ static int pch_i2c_resume(struct pci_dev *pdev)
                return -EIO;
        }
 
-       pci_enable_wake(pdev, PCI_D3hot, 0);
-
        for (i = 0; i < adap_info->ch_num; i++)
                pch_i2c_init(&adap_info->pch_data[i]);