Fix static analysis issue
authorJunghyun Yeon <jungh.yeon@samsung.com>
Thu, 25 Feb 2021 06:40:54 +0000 (15:40 +0900)
committerJunghyun Yeon <jungh.yeon@samsung.com>
Thu, 25 Feb 2021 06:40:54 +0000 (15:40 +0900)
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
src/manager/pkginfo_manager.cc

index 0231f02..4b56ce5 100644 (file)
@@ -116,17 +116,19 @@ extern "C" EXPORT_API char *_appinfo_get_localed_label(
 
        pkgmgr_client::PkgInfoClient client(parcelable, uid, 
                        pkgmgr_common::ReqType::QUERY);
-       if (!client.SendRequest())
+       if (!client.SendRequest()) {
+               sqlite3_free(query);
                return nullptr;
-       sqlite3_free(query);
+       }
+       
        std::shared_ptr<pkgmgr_common::parcel::ResultParcelable> return_parcel(
                                std::static_pointer_cast<pkgmgr_common::parcel::ResultParcelable>(
                                                client.GetResultParcel()));
        tizen_base::Parcel parcel;
        parcel.ReadParcelable(return_parcel.get());
-       
+       sqlite3_free(query);
        // result_list is vector of string vector
-       char *label;
+       char *label = nullptr;
        auto result_list = return_parcel->GetResult();
        for (auto result : result_list) {
                // result is string vector