edje_cc - make list free simpler to make analysers happy
authorCarsten Haitzler (Rasterman) <raster@rasterman.com>
Sat, 29 Jul 2017 00:44:54 +0000 (09:44 +0900)
committerCarsten Haitzler (Rasterman) <raster@rasterman.com>
Sat, 29 Jul 2017 00:44:54 +0000 (09:44 +0900)
analysers like PVS studio dont know the eina_list_free returning NULL
design pattern for consistency and so dislike the var being set twice
in a row. this will make them happy without any skin off our backs.
not a bug at all.

found by PVS studio

src/bin/edje/edje_cc_handlers.c

index 89e09ab..84c21b4 100644 (file)
@@ -15816,7 +15816,7 @@ edje_cc_handlers_pop_notify(const char *token)
      {
         current_program = sequencing;
         ((Edje_Program_Parser*)sequencing)->can_override = EINA_TRUE;
-        current_program_lookups = eina_list_free(current_program_lookups);
+        eina_list_free(current_program_lookups);
         current_program_lookups = sequencing_lookups;
         sequencing_lookups = NULL;
         sequencing = NULL;