Switch text param to nullable in WriteProcessingInstructionAsync (#41481)
authorDavid CantĂș <dacantu@microsoft.com>
Thu, 27 Aug 2020 23:54:03 +0000 (16:54 -0700)
committerGitHub <noreply@github.com>
Thu, 27 Aug 2020 23:54:03 +0000 (16:54 -0700)
src/libraries/System.Private.Xml/src/System/Xml/Core/XmlAsyncCheckWriter.cs
src/libraries/System.Private.Xml/src/System/Xml/Core/XmlCharCheckingWriterAsync.cs
src/libraries/System.Private.Xml/src/System/Xml/Core/XmlWellFormedWriterAsync.cs
src/libraries/System.Private.Xml/src/System/Xml/Core/XmlWrappingWriterAsync.cs
src/libraries/System.Private.Xml/src/System/Xml/Core/XmlWriterAsync.cs
src/libraries/System.Xml.ReaderWriter/ref/System.Xml.ReaderWriter.cs

index 9682986..d96b1b1 100644 (file)
@@ -432,7 +432,7 @@ namespace System.Xml
             return task;
         }
 
-        public override Task WriteProcessingInstructionAsync(string name, string text)
+        public override Task WriteProcessingInstructionAsync(string name, string? text)
         {
             CheckAsync();
             var task = _coreWriter.WriteProcessingInstructionAsync(name, text);
index 1a6395c..0c6d854 100644 (file)
@@ -137,7 +137,7 @@ namespace System.Xml
             return writer.WriteCommentAsync(text);
         }
 
-        public override Task WriteProcessingInstructionAsync(string name, string text)
+        public override Task WriteProcessingInstructionAsync(string name, string? text)
         {
             if (_checkNames)
             {
index 3657f95..f602537 100644 (file)
@@ -807,7 +807,7 @@ namespace System.Xml
             }
         }
 
-        public override async Task WriteProcessingInstructionAsync(string name, string text)
+        public override async Task WriteProcessingInstructionAsync(string name, string? text)
         {
             try
             {
index e727010..6edd2b7 100644 (file)
@@ -68,7 +68,7 @@ namespace System.Xml
             return writer.WriteCommentAsync(text);
         }
 
-        public override Task WriteProcessingInstructionAsync(string name, string text)
+        public override Task WriteProcessingInstructionAsync(string name, string? text)
         {
             return writer.WriteProcessingInstructionAsync(name, text);
         }
index 8b77dcf..d88d112 100644 (file)
@@ -120,7 +120,7 @@ namespace System.Xml
 
         // Writes out a processing instruction with a space between the name and text as follows: <?name text?>
 
-        public virtual Task WriteProcessingInstructionAsync(string name, string text)
+        public virtual Task WriteProcessingInstructionAsync(string name, string? text)
         {
             throw new NotImplementedException();
         }
index 4f8074e..2368267 100644 (file)
@@ -1288,7 +1288,7 @@ namespace System.Xml
         [System.Diagnostics.DebuggerStepThroughAttribute]
         public virtual System.Threading.Tasks.Task WriteNodeAsync(System.Xml.XPath.XPathNavigator navigator, bool defattr) { throw null; }
         public abstract void WriteProcessingInstruction(string name, string? text);
-        public virtual System.Threading.Tasks.Task WriteProcessingInstructionAsync(string name, string text) { throw null; }
+        public virtual System.Threading.Tasks.Task WriteProcessingInstructionAsync(string name, string? text) { throw null; }
         public virtual void WriteQualifiedName(string localName, string? ns) { }
         [System.Diagnostics.DebuggerStepThroughAttribute]
         public virtual System.Threading.Tasks.Task WriteQualifiedNameAsync(string localName, string? ns) { throw null; }