crypto: hisilicon/zip - replace 'sprintf' with 'scnprintf'
authorYang Shen <shenyang39@huawei.com>
Mon, 7 Sep 2020 08:21:56 +0000 (16:21 +0800)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 18 Sep 2020 07:20:09 +0000 (17:20 +1000)
Replace 'sprintf' with 'scnprintf' to avoid overrun.

Signed-off-by: Yang Shen <shenyang39@huawei.com>
Reviewed-by: Zhou Wang <wangzhou1@hisilicon.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/hisilicon/zip/zip_main.c

index df1a16f..dd2c326 100644 (file)
@@ -428,7 +428,7 @@ static ssize_t hisi_zip_ctrl_debug_read(struct file *filp, char __user *buf,
                return -EINVAL;
        }
        spin_unlock_irq(&file->lock);
-       ret = sprintf(tbuf, "%u\n", val);
+       ret = scnprintf(tbuf, sizeof(tbuf), "%u\n", val);
        return simple_read_from_buffer(buf, count, pos, tbuf, ret);
 }
 
@@ -518,9 +518,10 @@ static int hisi_zip_core_debug_init(struct hisi_qm *qm)
 
        for (i = 0; i < HZIP_CORE_NUM; i++) {
                if (i < HZIP_COMP_CORE_NUM)
-                       sprintf(buf, "comp_core%d", i);
+                       scnprintf(buf, sizeof(buf), "comp_core%d", i);
                else
-                       sprintf(buf, "decomp_core%d", i - HZIP_COMP_CORE_NUM);
+                       scnprintf(buf, sizeof(buf), "decomp_core%d",
+                                 i - HZIP_COMP_CORE_NUM);
 
                regset = devm_kzalloc(dev, sizeof(*regset), GFP_KERNEL);
                if (!regset)