slimbus: ngd: QCOM_QMI_HELPERS has to be selected
authorNiklas Cassel <niklas.cassel@linaro.org>
Mon, 12 Nov 2018 12:25:26 +0000 (12:25 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 27 Nov 2018 07:44:06 +0000 (08:44 +0100)
QCOM_QMI_HELPERS is a hidden kconfig, so the proper usage is
to select it, not depend upon it.

Because of this change, we now also need to depend on the same
Kconfigs as QCOM_QMI_HELPERS depends on.

Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/slimbus/Kconfig

index 9d73ad8..8cd5951 100644 (file)
@@ -22,8 +22,9 @@ config SLIM_QCOM_CTRL
 
 config SLIM_QCOM_NGD_CTRL
        tristate "Qualcomm SLIMbus Satellite Non-Generic Device Component"
-       depends on QCOM_QMI_HELPERS
-       depends on HAS_IOMEM && DMA_ENGINE
+       depends on HAS_IOMEM && DMA_ENGINE && NET
+       depends on ARCH_QCOM || COMPILE_TEST
+       select QCOM_QMI_HELPERS
        help
          Select driver if Qualcomm's SLIMbus Satellite Non-Generic Device
          Component is programmed using Linux kernel.