clk: imx: pll14xx: Return error if pll type is invalid
authorAnson Huang <Anson.Huang@nxp.com>
Fri, 21 Feb 2020 06:31:56 +0000 (14:31 +0800)
committerShawn Guo <shawnguo@kernel.org>
Mon, 24 Feb 2020 07:41:13 +0000 (15:41 +0800)
When pll type is invalid, ONLY output error message is NOT enough,
should return error immediately.

Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Reviewed-by: Stephen Boyd <sboyd@kernel.org>
Signed-off-by: Shawn Guo <shawnguo@kernel.org>
drivers/clk/imx/clk-pll14xx.c

index 37e311e..a83bbbe 100644 (file)
@@ -410,6 +410,8 @@ struct clk_hw *imx_clk_hw_pll14xx(const char *name, const char *parent_name,
        default:
                pr_err("%s: Unknown pll type for pll clk %s\n",
                       __func__, name);
+               kfree(pll);
+               return ERR_PTR(-EINVAL);
        };
 
        pll->base = base;