Legalization: Fix warnings and disable tests when spirv-tools not present
authorGregF <greg@LunarG.com>
Thu, 28 Sep 2017 16:08:32 +0000 (10:08 -0600)
committerGregF <greg@LunarG.com>
Thu, 28 Sep 2017 16:13:23 +0000 (10:13 -0600)
StandAlone/StandAlone.cpp
gtests/Hlsl.FromFile.cpp

index d2587c1..f427179 100644 (file)
@@ -896,8 +896,8 @@ void CompileAndLinkShaderUnits(std::vector<ShaderCompUnit> compUnits)
                     glslang::SpvOptions spvOptions;
                     if (Options & EOptionDebug)
                         spvOptions.generateDebugInfo = true;
-                    spvOptions.disableOptimizer = Options & EOptionOptimizeDisable;
-                    spvOptions.optimizeSize = Options & EOptionOptimizeSize;
+                    spvOptions.disableOptimizer = (Options & EOptionOptimizeDisable) != 0;
+                    spvOptions.optimizeSize = (Options & EOptionOptimizeSize) != 0;
                     glslang::GlslangToSpv(*program.getIntermediate((EShLanguage)stage), spirv, &logger, &spvOptions);
 
                     // Dump the spv to a file or stdout, etc., but only if not doing
index 51c2a4b..4e810de 100644 (file)
@@ -366,6 +366,7 @@ INSTANTIATE_TEST_CASE_P(
 );
 // clang-format on
 
+#ifdef ENABLE_OPT
 // clang-format off
 INSTANTIATE_TEST_CASE_P(
     ToSpirv, HlslLegalizeTest,
@@ -378,6 +379,7 @@ INSTANTIATE_TEST_CASE_P(
     FileNameAsCustomTestSuffix
 );
 // clang-format on
+#endif
 
 }  // anonymous namespace
 }  // namespace glslangtest