mm/z3fold: remove redundant list_del_init of zhdr->buddy in z3fold_free
authorMiaohe Lin <linmiaohe@huawei.com>
Fri, 29 Apr 2022 06:16:06 +0000 (23:16 -0700)
committerakpm <akpm@linux-foundation.org>
Fri, 29 Apr 2022 06:16:06 +0000 (23:16 -0700)
do_compact_page() will do list_del_init(&zhdr->buddy) for us.  Remove this
extra one to save some possible cpu cycles.

Link: https://lkml.kernel.org/r/20220308134311.59086-8-linmiaohe@huawei.com
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Reviewed-by: Vitaly Wool <vitaly.wool@konsulko.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/z3fold.c

index 18a697f..867c590 100644 (file)
@@ -1244,9 +1244,6 @@ static void z3fold_free(struct z3fold_pool *pool, unsigned long handle)
                return;
        }
        if (zhdr->cpu < 0 || !cpu_online(zhdr->cpu)) {
-               spin_lock(&pool->lock);
-               list_del_init(&zhdr->buddy);
-               spin_unlock(&pool->lock);
                zhdr->cpu = -1;
                kref_get(&zhdr->refcount);
                clear_bit(PAGE_CLAIMED, &page->private);