[media] lirc_dev: remove pointless functions
authorDavid Härdeman <david@hardeman.nu>
Mon, 1 May 2017 16:03:41 +0000 (13:03 -0300)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Tue, 6 Jun 2017 11:59:28 +0000 (08:59 -0300)
drv->set_use_inc and drv->set_use_dec are already optional so we can
remove all dummy functions.

Signed-off-by: David Härdeman <david@hardeman.nu>
Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/rc/ir-lirc-codec.c
drivers/staging/media/lirc/lirc_zilog.c

index 8f0669c..fc58745 100644 (file)
@@ -327,16 +327,6 @@ static long ir_lirc_ioctl(struct file *filep, unsigned int cmd,
        return ret;
 }
 
-static int ir_lirc_open(void *data)
-{
-       return 0;
-}
-
-static void ir_lirc_close(void *data)
-{
-       return;
-}
-
 static const struct file_operations lirc_fops = {
        .owner          = THIS_MODULE,
        .write          = ir_lirc_transmit_ir,
@@ -396,8 +386,8 @@ static int ir_lirc_register(struct rc_dev *dev)
        drv->features = features;
        drv->data = &dev->raw->lirc;
        drv->rbuf = NULL;
-       drv->set_use_inc = &ir_lirc_open;
-       drv->set_use_dec = &ir_lirc_close;
+       drv->set_use_inc = NULL;
+       drv->set_use_dec = NULL;
        drv->code_length = sizeof(struct ir_raw_event) * 8;
        drv->chunk_size = sizeof(int);
        drv->buffer_size = LIRCBUF_SIZE;
index 8ce1db0..123933f 100644 (file)
@@ -497,15 +497,6 @@ static int lirc_thread(void *arg)
        return 0;
 }
 
-static int set_use_inc(void *data)
-{
-       return 0;
-}
-
-static void set_use_dec(void *data)
-{
-}
-
 /* safe read of a uint32 (always network byte order) */
 static int read_uint32(unsigned char **data,
                                     unsigned char *endp, unsigned int *val)
@@ -1396,8 +1387,6 @@ static struct lirc_driver lirc_template = {
        .buffer_size    = BUFLEN / 2,
        .sample_rate    = 0, /* tell lirc_dev to not start its own kthread */
        .chunk_size     = 2,
-       .set_use_inc    = set_use_inc,
-       .set_use_dec    = set_use_dec,
        .fops           = &lirc_fops,
        .owner          = THIS_MODULE,
 };