srtpenc: improve property comments
authorWim Taymans <wtaymans@redhat.com>
Wed, 18 Jun 2014 13:36:09 +0000 (15:36 +0200)
committerWim Taymans <wtaymans@redhat.com>
Wed, 18 Jun 2014 13:37:23 +0000 (15:37 +0200)
Add a Note to the allow-repeat-tx property because it is potentially
insecure when used incorrectly.

Fixes https://bugzilla.gnome.org/show_bug.cgi?id=731714

ext/srtp/gstsrtpenc.c

index 276076f..2dd4bc9 100644 (file)
@@ -324,8 +324,11 @@ gst_srtp_enc_class_init (GstSrtpEncClass * klass)
           64, 0x8000, DEFAULT_REPLAY_WINDOW_SIZE,
           G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS));
   g_object_class_install_property (gobject_class, PROP_ALLOW_REPEAT_TX,
-      g_param_spec_boolean ("allow-repeat-tx", "Allow repeat packets transmission",
-          "Whether retransmissions of packets with the same sequence number are allowed",
+      g_param_spec_boolean ("allow-repeat-tx",
+          "Allow repeat packets transmission",
+          "Whether retransmissions of packets with the same sequence number are allowed"
+          "(Note that such repeated transmissions must have the same RTP payload, "
+          "or a severe security weakness is introduced!)",
           DEFAULT_ALLOW_REPEAT_TX, G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS));
 
   /**